[AI-assisted] fix(android): wrap onboarding permission labels#103649
[AI-assisted] fix(android): wrap onboarding permission labels#103649Solvely-Colin merged 2 commits into
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 10, 2026, 8:30 AM ET / 12:30 UTC. Summary PR surface: Other -2. Total -2 across 2 files. Reproducibility: yes. The before emulator artifact visibly reproduces clipped permission explanations, matching current main's explicit one-line constraints. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Next step before merge
Security Review detailsBest possible solution: Land the minimal multiline change after the normal exact-head merge checks, preserving the existing weighted row and scrollable permissions layout. Do we have a high-confidence way to reproduce the issue? Yes. The before emulator artifact visibly reproduces clipped permission explanations, matching current main's explicit one-line constraints. Is this the best way to solve the issue? Yes. Removing only the two AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 0426f238c363. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Other -2. Total -2 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Co-authored-by: IWhatsskill <284122573+IWhatsskill@users.noreply.github.com>
What Problem This Solves
On the Android onboarding permissions screen, permission titles and descriptions were constrained to one line. At larger font scales or narrow widths, longer text was truncated, hiding part of the permission explanation.
Why This Change Was Made
This removes the single-line limits from both text elements in
PermissionRow, allowing Compose to grow each row vertically and wrap the full title and description. The native i18n source index is refreshed for the resulting source line shifts.User Impact
Permission labels remain fully readable instead of being clipped or shortened, including at increased Android font scale.
Evidence
Verified on an Android API 36 emulator at 1080�2400 and 1.5 font scale using a real paired, online Gateway. Before, permission descriptions were restricted to one line; after, they wrap across multiple lines without truncation. The paired proof state was Gateway online, Nodes 1/1, Approvals 0, with device and node pending queues empty.
Before video:
before-permission.mp4
After video:
after-permission-wrap.mp4
Validation:
pnpm native:i18n:checkpassed withchanged=falseand 2,916 entries.pnpm android:i18n:checkpassed with 21 keys across all locales../gradlew --offline --no-daemon :app:ktlintCheck :benchmark:ktlintCheck --console=plainpassed../gradlew --offline --no-daemon :app:assemblePlayDebug --console=plainpassed.