Skip to content

fix(security): clarify dmScope remediation path with explicit CLI command#13129

Merged
steipete merged 3 commits into
openclaw:mainfrom
VintLin:fix/security-audit-path-v2
Feb 13, 2026
Merged

fix(security): clarify dmScope remediation path with explicit CLI command#13129
steipete merged 3 commits into
openclaw:mainfrom
VintLin:fix/security-audit-path-v2

Conversation

@VintLin
Copy link
Copy Markdown
Contributor

@VintLin VintLin commented Feb 10, 2026

Problem

The security audit and onboarding screens suggested 'Set session.dmScope="..."'
for multi-user DM isolation. This led users to try setting the value in invalid
config paths (e.g., 'channels.imessage.dmScope').

Changes

  • Updated 'src/security/audit.ts' to use 'formatCliCommand' for dmScope remediation.
  • Updated 'src/commands/doctor-security.ts' and 'src/commands/onboard-channels.ts'
    to use the explicit 'openclaw config set' command format.

Validation

  • Verified text alignment with 'pnpm tsgo'.
  • Confirmed CLI command formatting remains consistent across modified files.

Fixes:#11642

Greptile Overview

Greptile Summary

This PR updates user-facing security guidance around DM session isolation (dmScope) to reduce confusion about where to set the config.

  • src/security/audit.ts now recommends an explicit openclaw config set session.dmScope "per-channel-peer" CLI command (via formatCliCommand) instead of suggesting users manually edit a config path.
  • src/commands/doctor-security.ts and src/commands/onboard-channels.ts similarly switch the DM-scope remediation text to an explicit CLI command, keeping the formatting consistent with other CLI hints (including profile injection handled by formatCliCommand).

No behavioral/security logic changes were introduced; this is primarily a messaging/UX clarification that aligns onboarding + audit output with supported configuration workflows.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • Changes are limited to user-facing remediation strings and reuse the existing formatCliCommand helper; no control flow or security decision logic was modified. Verified the helper’s behavior with quoted arguments and found no whitespace/format issues in the diff.
  • No files require special attention

@openclaw-barnacle openclaw-barnacle Bot added the commands Command implementations label Feb 10, 2026
VintLin and others added 3 commits February 13, 2026 16:39
…mand

# Problem
The security audit and onboarding screens suggested 'Set session.dmScope="..."'
for multi-user DM isolation. This led users to try setting the value in invalid
config paths (e.g., 'channels.imessage.dmScope').

# Changes
- Updated 'src/security/audit.ts' to use 'formatCliCommand' for dmScope remediation.
- Updated 'src/commands/doctor-security.ts' and 'src/commands/onboard-channels.ts'
  to use the explicit 'openclaw config set' command format.

# Validation
- Verified text alignment with 'pnpm tsgo'.
- Confirmed CLI command formatting remains consistent across modified files.
@steipete steipete force-pushed the fix/security-audit-path-v2 branch from 73dc309 to 58f8b34 Compare February 13, 2026 15:43
@steipete steipete merged commit 4337fa2 into openclaw:main Feb 13, 2026
9 checks passed
@steipete
Copy link
Copy Markdown
Contributor

Landed via temp rebase onto main.

  • Gate: pnpm check && pnpm build && pnpm test (blocked by unrelated upstream TS/e2e failures on current main); targeted coverage: pnpm test src/security/audit.test.ts and pnpm test:e2e (doctor/onboard tests passed in run output)
  • Land commit: 58f8b34
  • Merge commit: 4337fa2

Thanks @VintLin!

skyhawk14 pushed a commit to skyhawk14/openclaw that referenced this pull request Feb 13, 2026
skyhawk14 pushed a commit to skyhawk14/openclaw that referenced this pull request Feb 13, 2026
GwonHyeok pushed a commit to learners-superpumped/openclaw that referenced this pull request Feb 15, 2026
GwonHyeok pushed a commit to learners-superpumped/openclaw that referenced this pull request Feb 15, 2026
jiulingyun added a commit to jiulingyun/openclaw-cn that referenced this pull request Feb 15, 2026
hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 1, 2026
…w#13129) (thanks @VintLin)

(cherry picked from commit 4337fa2)

# Conflicts:
#	src/commands/doctor-security.test.ts
hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 1, 2026
hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 3, 2026
…w#13129) (thanks @VintLin)

(cherry picked from commit 4337fa2)

# Conflicts:
#	src/commands/doctor-security.test.ts
hughdidit pushed a commit to hughdidit/DAISy-Agency that referenced this pull request Mar 3, 2026
…@VintLin)

(cherry picked from commit f612e35)

# Conflicts:
#	CHANGELOG.md
#	src/commands/doctor-security.test.ts
zooqueen pushed a commit to hanzobot/core that referenced this pull request Mar 6, 2026
zooqueen pushed a commit to hanzobot/core that referenced this pull request Mar 6, 2026
lovewanwan pushed a commit to lovewanwan/openclaw that referenced this pull request Apr 28, 2026
lovewanwan pushed a commit to lovewanwan/openclaw that referenced this pull request Apr 28, 2026
ogt-redknie pushed a commit to ogt-redknie/OPENX that referenced this pull request May 2, 2026
ogt-redknie pushed a commit to ogt-redknie/OPENX that referenced this pull request May 2, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commands Command implementations size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants