fix(config): redact sourceConfig and runtimeConfig alias fields in redactConfigSnapshot [AI]

[pgondhi987]

Summary

• Problem: redactConfigSnapshot() spread ...snapshot then only overwrote config and resolved with redacted copies, leaving sourceConfig and runtimeConfig (the canonical alias fields) pointing to the original unredacted objects. Any caller reading those fields received plaintext secrets.
• Why it matters: The config.get gateway RPC serializes the full snapshot output to authenticated clients. A session with operator.read scope could extract all stored secrets (API keys, auth tokens, channel credentials) via the unredacted alias fields.
• What changed: redactConfigSnapshot now explicitly overwrites sourceConfig (set to redactedResolved) and runtimeConfig (set to redactedConfig) in both the valid-snapshot and invalid-snapshot return paths. Test coverage added for both new fields.
• What did NOT change: Redaction logic for config, resolved, raw, and parsed is unchanged. No gateway RPC surface, scope model, or schema changed.

AI-assisted: This fix was generated by OpenAI Codex and reviewed prior to submission.

Change Type (select all)

• Bug fix
• Feature
• Refactor required for the fix
• Docs
• Security hardening
• Chore/infra

Scope (select all touched areas)

• Gateway / orchestration
• Skills / tool execution
• Auth / tokens
• Memory / storage
• Integrations
• API / contracts
• UI / DX
• CI/CD / infra

Linked Issue/PR

• This PR fixes a bug or regression

Root Cause (if applicable)

• Root cause: redactObject() returns new objects rather than mutating in place. The object spread copies the original sourceConfig and runtimeConfig references, and the subsequent explicit overrides only covered the deprecated aliases (config, resolved), not the canonical fields.
• Missing detection / guardrail: No test asserted result.sourceConfig or result.runtimeConfig were redacted — only the deprecated alias fields were checked.
• Contributing context: sourceConfig/runtimeConfig were introduced as canonical replacements for resolved/config but the redaction function was not updated in lockstep.

Regression Test Plan (if applicable)

• Coverage level that should have caught this:
  • Unit test
• Target test or file: src/config/redact-snapshot.test.ts
• Scenario the test should lock in: Both result.sourceConfig and result.runtimeConfig contain REDACTED_SENTINEL for known-sensitive values; both alias pairs are referentially equal (sourceConfig === resolved, runtimeConfig === config).
• Why this is the smallest reliable guardrail: Directly exercises the output shape of redactConfigSnapshot without any gateway layer.
• Existing test that already covered this: None — only result.config and result.resolved were previously asserted.

User-visible / Behavior Changes

None. sourceConfig and runtimeConfig were already supposed to be redacted; this makes the behavior match the documented contract.

Diagram (if applicable)

Before:
redactConfigSnapshot() -> { ...snapshot,   // sourceConfig/runtimeConfig: UNREDACTED
                            config: redacted,
                            resolved: redacted }

After:
redactConfigSnapshot() -> { ...snapshot,
                            sourceConfig: redacted,  // now explicit
                            runtimeConfig: redacted, // now explicit
                            config: redacted,
                            resolved: redacted }

Security Impact (required)

• New permissions/capabilities? No
• Secrets/tokens handling changed? Yes — sourceConfig and runtimeConfig fields are now properly redacted before being returned by redactConfigSnapshot.
• New/changed network calls? No
• Command/tool execution surface changed? No
• Data access scope changed? No
• Risk + mitigation: The change narrows data exposure. The only risk is if a caller depended on receiving unredacted values via these fields, which would be an incorrect usage against the documented contract.

Repro + Verification

Environment

• OS: Linux (CI)
• Runtime/container: Node 22 / Bun
• Model/provider: N/A
• Integration/channel: N/A
• Relevant config: Any config with gateway.auth.token or channels.discord.token set

Steps

1. Run pnpm test src/config/redact-snapshot.test.ts
2. Observe new assertions pass: result.sourceConfig and result.runtimeConfig both contain REDACTED_SENTINEL
3. Observe identity assertions pass: result.sourceConfig === result.resolved, result.runtimeConfig === result.config

Expected

• All redaction tests pass including the new alias-field assertions

Actual

• All tests pass

Evidence

• Failing test/log before + passing after

New test cases added to redact-snapshot.test.ts directly assert the previously-unredacted fields now contain REDACTED_SENTINEL.

Human Verification (required)

• Verified scenarios: Valid-snapshot redaction path (both alias fields redacted); invalid-snapshot branch (both alias fields return {}); referential equality maintained between alias pairs.
• Edge cases checked: sourceConfig === resolved and runtimeConfig === config identity preserved so downstream code relying on reference equality is unaffected.
• What you did not verify: Live gateway RPC round-trip with a real scoped session.

Review Conversations

• I replied to or resolved every bot review conversation I addressed in this PR.
• I left unresolved only the conversations that still need reviewer or maintainer judgment.

Compatibility / Migration

• Backward compatible? Yes
• Config/env changes? No
• Migration needed? No

Risks and Mitigations

• Risk: A caller that expected sourceConfig/runtimeConfig to be unredacted (incorrect usage) would now receive redacted values.
  • Mitigation: No such caller exists in the codebase; these fields are exclusively read-only outputs of redactConfigSnapshot and no code path depends on receiving unredacted aliases from this function.

[greptile-apps]

Greptile Summary

This PR fixes a security regression in redactConfigSnapshot where the spread of ...snapshot left sourceConfig and runtimeConfig pointing to the original unredacted objects, while only config and resolved were explicitly overridden with redacted copies. The fix adds explicit overrides for both canonical alias fields in both the valid and invalid snapshot return paths, with matching test assertions for reference equality and sentinel values.

Confidence Score: 5/5

This PR is safe to merge — it is a minimal, correct security fix with no logic changes outside the targeted redaction function.

The change is narrowly scoped: two fields added to two return statements, with matching tests that check both sentinel values and reference equality. The type definitions confirm sourceConfig/resolved are the same ResolvedSourceConfig type and runtimeConfig/config are the same RuntimeConfig type, so the aliasing is correct. No other fields in ConfigFileSnapshot are unredacted aliases.

No files require special attention.

_{Reviews (1): Last reviewed commit: "fix: address issue" | Re-trigger Greptile}

[pavan987]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".