fix(signal): avoid duplicate signal-cli missing note#96932
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(signal): avoid duplicate signal-cli missing note This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
Jun 26, 2026
This was referenced Jun 26, 2026
QiuYuang
pushed a commit
to QiuYuang/openclaw
that referenced
this pull request
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Signal QuickStart could show two consecutive missing-binary notes after
signal-cliinstallation failed: first the installer failure from the Signal prepare step, then the generic cliPath help note before asking forsignal-cli path.Why This Change Was Made
The path prompt itself is already the recovery action, and the installer failure already explains the failure. Removing the Signal-specific cliPath help note keeps the setup flow to one error note plus the path prompt without adding wizard state or changing shared setup behavior.
User Impact
Users see one Signal install failure message instead of two similar Signal missing-binary messages, then can still enter a custom
signal-clipath.Evidence
pnpm test extensions/signal/src/core.test.ts -- --reporter=verbosepnpm exec oxfmt --check --threads=1 extensions/signal/src/setup-core.ts extensions/signal/src/core.test.tsgit diff --checknode scripts/run-oxlint.mjs --tsconfig config/tsconfig/oxlint.extensions.json extensions/signal/src/setup-core.ts extensions/signal/src/core.test.tspnpm tsgo:extensionspnpm tsgo:extensions:testpnpm check:changed -- extensions/signal/src/setup-core.ts extensions/signal/src/core.test.tsvia Blacksmith Testboxtbx_01kw12d6xprcv4gw3c8hb6pwg6.agents/skills/autoreview/scripts/autoreview --mode local --prompt "Review this focused OpenClaw Signal setup copy fix. Scope: avoid duplicate Signal missing-binary notes by removing the generic Signal cliPath help note; installer failure remains and the path prompt still appears. Touched files: extensions/signal/src/setup-core.ts and extensions/signal/src/core.test.ts. Focus on setup UX, wizard behavior, and test value."