Fix type_body_length lint warning in EventKitStore#29
Closed
philoserf wants to merge 1 commit into
Closed
Conversation
… warning Replace 3 inline ReminderItem constructions in createReminder, updateReminder, and completeReminders with calls to the existing item(from:) helper. No behavior change. Closes openclaw#28 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
This was existing lint noticed upon first examination of the source. |
5 tasks
jakubswierczek
added a commit
to jakubswierczek/remindctl
that referenced
this pull request
Mar 30, 2026
…claw#29) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jakubswierczek
added a commit
to jakubswierczek/remindctl
that referenced
this pull request
Mar 30, 2026
resolved conflict with openclaw#29 refactor — creationDate added to item(from:) helper Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jakubswierczek
added a commit
to jakubswierczek/remindctl
that referenced
this pull request
Mar 30, 2026
…law#30) resolved conflicts with openclaw#29 refactor and openclaw#13 creationDate — added dueDateIsAllDay to ReminderItem, item(from:), and fetchReminders Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
hezhongtang
added a commit
to hezhongtang/remindctl
that referenced
this pull request
Apr 17, 2026
Merged 9 PRs from steipete/remindctl: - openclaw#29 lint fix, openclaw#26 open filter, openclaw#35 tags support - openclaw#30 all-day/date-only reminders, openclaw#40 recurrence rules - openclaw#39 alarm support, openclaw#27 reminder sections - openclaw#44 isFlagged support, openclaw#13 creationDate in output
Collaborator
|
Thanks, Mark. This cleanup is now on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReminderItem(...)constructions with calls to the existingitem(from:)helper that was never being usedRemindersStoreactor body well under SwiftLint's 250-line thresholdCloses #28
Test plan
make lint— 0 violationsswift test— all 22 tests pass🤖 Generated with Claude Code