chore(deps): refresh CrawlKit and Cloudsmith CLI - #167
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. |
|
Codex review: needs maintainer review before merge. Reviewed August 31, 2026, 2:10 PM ET / 18:10 UTC. ClawSweeper reviewWhat this changesThe branch updates CrawlKit to v0.14.8 for a bounded release-check timeout and upgrades the Cloudsmith CLI used by manual APT and RPM publishing workflows. Merge readinessKeep open for explicit collaborator/maintainer review. The pinned branch contains the requested timeout and publishing-tool updates, has strong supplied runtime evidence, and no concrete patch defect was found. Priority: P2 Review scores
Verification
How this fits togetherSlacrawl delegates its release-update check to CrawlKit, while separate manually run GitHub workflows publish Debian and RPM release assets to Cloudsmith. This change updates that shared release-check dependency and the publishing CLI installed by those workflows. flowchart LR
C[Slacrawl command] --> R[Release checker]
R --> H[GitHub release request]
H --> T[30-second timeout]
B[Release packages] --> A[APT publish workflow]
B --> P[RPM publish workflow]
A --> S[Cloudsmith CLI]
P --> S
S --> O[Cloudsmith repository]
Decision needed
Why: The remaining uncertainty concerns a production-secret manual release operation that cannot be fully exercised by the supplied credential-free proof. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the timeout fix as a CrawlKit dependency upgrade and merge the exact Cloudsmith pin once a maintainer accepts the bounded manual-publication compatibility risk. Do we have a high-confidence way to reproduce the issue? Yes: the supplied terminal trace gives a concrete stalled-proxy scenario for a versioned Slacrawl binary and records the expected bounded timeout after the update. Is this the best way to solve the issue? Yes for the release-check hang: Slacrawl already delegates this behavior to CrawlKit, so consuming the fixed dependency release is narrower than duplicating its HTTP logic; Cloudsmith acceptance remains a release-workflow decision. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 1816d30bbbde. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
History |
|
Delta triage: NEEDS-PETER for the Cloudsmith publication-proof decision. The CrawlKit timeout fix is independently reproduced and ready for review; no code changes are needed from this pass. Reviewed head: Root cause: Slacrawl delegates Independent built-binary proof on macOS arm64: Codex autoreview returned Decision brief: accept the minor Cloudsmith CLI pin update based on installation and unchanged command-interface proof, or defer those two pins and land the independently verified CrawlKit fix. I recommend accepting the compatible pin refresh, while recording that authenticated Cloudsmith publication has not been exercised. If stronger service proof is required, a maintainer must authorize and run a controlled upload to a designated repository. This worker has no release/publication authority, so no real package upload was attempted. No new credential permissions, API design, or destinations are introduced by this PR. PR remains open for the orchestrator; nothing was merged or published. |
What Problem This Solves
Refreshes the two remaining out-of-date dependencies. CrawlKit's release checker previously used an HTTP client without a timeout, so
check-updatecould hang on an unresponsive server.Why This Change Was Made
github.com/openclaw/crawlkitfrom v0.14.7 to v0.14.8, regeneratinggo.mod/go.sumwithGOWORK=off go get -u -t ./...andGOWORK=off go mod tidy. Upstream release.No major upgrades taken. Deferred major / maintainer decision: Bubble Tea, Bubbles, and Lip Gloss v2 use new
charm.land/.../v2module paths and incompatible view/input APIs (migration guide). Slacrawl imports CrawlKit's TUI; CrawlKit owns all three v1 dependencies. Recommend migrating the shared TUI in CrawlKit first, then consuming its release here, instead of forking or replacing that implementation in Slacrawl.User Impact
Release-check HTTP requests now time out after 30 seconds. The changelog and command reference describe that behavior. Cloudsmith changes affect only manually invoked package publication.
Evidence
Local validation on macOS arm64, Go 1.27.0:
The snapshot built Linux/macOS AMD64/ARM64 binaries, archives, and Debian/RPM packages with
--snapshot --skip=publish.actionlintandgit diff --checkalso exited 0. Codex autoreview returnedscoped-clean, with no findings at the requested default P0 priority.Built CLI on a disposable Slack export
Created a synthetic export with one user, one channel, and two messages (one thread reply containing
café 🦞), with a dedicated config/database and all live sources disabled. Real command/output excerpts:The terminal check used a Python PTY harness that waited for both messages to render, sent
q, and asserted exit 0.Release-check timeout
Built a versioned CLI so the release checker would execute. A loopback HTTP proxy accepted its
CONNECT api.github.com:443request and deliberately withheld a response; the harness required the client's timeout error and a bounded exit:Elapsed wall time includes process startup/scheduling on the shared host. The nonzero exit is the expected successful proof of timeout handling.
Cloudsmith workflow command compatibility
Installed the pinned version into a disposable Python virtual environment:
No authenticated package publication was run.
CI reasoning
Default branch was green at
1816d30: CI, Docker build/smoke, CodeQL, and secret scanning.CIanddockerare build/test gates. CodeQL and secret scanning are security gates. ClawSweeper dispatch, stale maintenance, release drafting, and manual Crabbox/release/Cloudsmith workflows are operational automation. No tests, assertions, or workflow gates were weakened. PR validation is green at508c23a: CI — deps, lint, tests, and release snapshot, Docker build/smoke, CodeQL, and secret scanning. No failures or reruns were needed. The manual publishing workflows were validated locally without dispatching them.