Skip to content

fix(thumbnails): public link thumbnails never generated behind compressed proxy - #3454

Draft
ThShepard wants to merge 1 commit into
opencloud-eu:mainfrom
ThShepard:fix/public-link-thumbnails-without-content-length
Draft

fix(thumbnails): public link thumbnails never generated behind compressed proxy#3454
ThShepard wants to merge 1 commit into
opencloud-eu:mainfrom
ThShepard:fix/public-link-thumbnails-without-content-length

Conversation

@ThShepard

Copy link
Copy Markdown

Description

This changes the behavior of the thumbnail generation process by not relying on the Content-Length header. Instead thumbnails would generate based on the real size of the image.

Related Issue

Motivation and Context

This change fixes thumbnail generation of publicly shared pictures behind a reverse proxy which is set up for gzip compression of every data type.

How Has This Been Tested?

  • test environment: macOS and locally built OpenCloud with reverse proxy
  • test case 1: gzip enabled, preview not already generated
  • test case 2: gzip disabled, preview not already generated

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 7 complexity · 0 duplication

Metric Results
Complexity 7
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@butonic

butonic commented Sep 3, 2026

Copy link
Copy Markdown
Member

this looks interesting, however I am currently looking into a oush based architecture for the thumbnailer in #3397

I'm not sure this applies there. Could you review that PR and see if it solves your problem?

@ThShepard

Copy link
Copy Markdown
Author

Thanks @butonic, I have tested your implementation locally and the bug is mitigated completely. As this class is deleted completely in your PR, should this one be closed or could this be used as a mitigation until yours is merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when sharing a directory with images via a public link when gzip compression is enabled for images

2 participants