fix(thumbnails): public link thumbnails never generated behind compressed proxy - #3454
Draft
ThShepard wants to merge 1 commit into
Draft
Conversation
…ssing reverse proxy
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 7 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Member
|
this looks interesting, however I am currently looking into a oush based architecture for the thumbnailer in #3397 I'm not sure this applies there. Could you review that PR and see if it solves your problem? |
Author
|
Thanks @butonic, I have tested your implementation locally and the bug is mitigated completely. As this class is deleted completely in your PR, should this one be closed or could this be used as a mitigation until yours is merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This changes the behavior of the thumbnail generation process by not relying on the Content-Length header. Instead thumbnails would generate based on the real size of the image.
Related Issue
Motivation and Context
This change fixes thumbnail generation of publicly shared pictures behind a reverse proxy which is set up for gzip compression of every data type.
How Has This Been Tested?
Types of changes
Checklist: