Skip to content

fix(maps): location panel rendering #387

Merged
JammingBen merged 3 commits intomainfrom
fix/maps-location-panel
Mar 12, 2026
Merged

fix(maps): location panel rendering #387
JammingBen merged 3 commits intomainfrom
fix/maps-location-panel

Conversation

@JammingBen
Copy link
Copy Markdown
Member

The onPanelActive has been removed with Web v6. Removes the method call here because it doesn't seem to be necessary.

The `onPanelActive` has been removed with Web v6. Removes the method
call here because it doesn't seem to be necessary.
@JammingBen JammingBen self-assigned this Mar 12, 2026
@JammingBen JammingBen requested a review from dschmidt March 12, 2026 10:51
@dschmidt
Copy link
Copy Markdown
Contributor

Hmmm... what was it used for before? Is the initialized still needed at all? 🤔

@JammingBen
Copy link
Copy Markdown
Member Author

Hmmm... what was it used for before? Is the initialized still needed at all? 🤔

Just tried hardcoding it to true initially and everything seems to work 🤷 So I guess we can remove it, if you also don't have some idea what this might do/fix?

@dschmidt
Copy link
Copy Markdown
Contributor

Dunno, there must be a watcher then - what's that doing?

@JammingBen
Copy link
Copy Markdown
Member Author

Dunno, there must be a watcher then - what's that doing?

I don't see any watcher here. But let's maybe keep it to ensure it doesn't break anything else.

The active panel check on the other hand can safely go I think. It's a root panel, so when the component gets mounted, it's active.

@dschmidt
Copy link
Copy Markdown
Contributor

Well if it doesnt has any use, let's remove it... no use in leaving dead code. If it breaks something, we can fix it again

@JammingBen
Copy link
Copy Markdown
Member Author

Well if it doesnt has any use, let's remove it... no use in leaving dead code. If it breaks something, we can fix it again

Alright, removed it 👍

Comment thread packages/web-app-maps/src/components/LocationPanel.vue Outdated
@JammingBen JammingBen force-pushed the fix/maps-location-panel branch from 4fdcb13 to c363391 Compare March 12, 2026 12:52
@JammingBen JammingBen force-pushed the fix/maps-location-panel branch from c363391 to 9bc8766 Compare March 12, 2026 12:53
@JammingBen JammingBen requested a review from dschmidt March 12, 2026 13:46
Copy link
Copy Markdown
Contributor

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks!

@JammingBen JammingBen merged commit 878fe5e into main Mar 12, 2026
5 checks passed
@JammingBen JammingBen deleted the fix/maps-location-panel branch March 12, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants