Skip to content

fix: add space after password label when copying#2881

Merged
kulmann merged 1 commit into
mainfrom
fix-password-copy-spacing
Jul 14, 2026
Merged

fix: add space after password label when copying#2881
kulmann merged 1 commit into
mainfrom
fix-password-copy-spacing

Conversation

@Svanvith

Copy link
Copy Markdown
Contributor

Description

This change adds a space after Password: when copying a public link together with its password.

Currently, the password starts immediately after the colon:

https://cloud.docs.opencloud.rocks/s/KKLPLdXPWRzHDkm Password:!=U8#9CSgHth

After this change, the copied text contains a space between the label and the password:

https://cloud.docs.opencloud.rocks/s/KKLPLdXPWRzHDkm Password: !=U8#9CSgHth

This improves readability and makes it easier to distinguish the password from the Password: label.

Copied link and password without a space after the Password label

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear

AlexAndBear commented Jul 14, 2026

Copy link
Copy Markdown
Member

Needs pm decision @tbsbdr @kulmann

Pitfall: users might copy the space as well and wondering why their password is not working.

@kulmann

kulmann commented Jul 14, 2026

Copy link
Copy Markdown
Member

Pitfall: users might copy the space as well and wondering why their password is not working.

I think the risk for that is low enough.

@kulmann
kulmann merged commit 285596d into main Jul 14, 2026
31 checks passed
@kulmann
kulmann deleted the fix-password-copy-spacing branch July 14, 2026 10:18
@openclouders openclouders mentioned this pull request Jul 14, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants