perf: improve file selection in tiles view#2939
Merged
Merged
Conversation
- Use Set-based O(1) membership checks instead of Array.includes/indexOf in useResourceViewHelpers (isResourceSelected) and the resources store - Drop the now-unused selectedResources computed from useResourceViewHelpers by deriving the drag selection from resources + selectedIds in useResourceViewDrag
ResourceTile now derives its own selected state from the resources store (via a shared selectedIdsSet getter) instead of receiving it as a prop and exposes it to the selection slot as a scoped prop. This removes the last selectedIds reads from ResourceTiles' render, so a selection toggle no longer re-renders the whole list. Only the tiles whose selected boolean actually flips re-render (Vue's computed change detection), instead of replaying every tile's slot code and per-item helpers.
JammingBen
commented
Jul 22, 2026
| :drag-drop="dragDrop" | ||
| :hover="hover" | ||
| :item-dom-selector="resourceDomSelector" | ||
| :selection="selectedResources" |
Member
Author
There was a problem hiding this comment.
This prop doesn't exist on OcTable.
AlexAndBear
approved these changes
Jul 23, 2026
AlexAndBear
left a comment
AlexAndBear
left a comment
Member
There was a problem hiding this comment.
Didn't measure the improvement but altogether this makes totally sense 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResourceTilenow derives its own selected state from the resources store instead of receiving it as a prop and exposes it to the selection slot as a scoped prop. This removes allselectedIdsreads fromResourceTiles' render, so a selection toggle no longer re-renders the whole list.Further improves selection performance by using a Set-based O(1) membership checks instead of
Array.includes/indexOfinuseResourceViewHelpers(isResourceSelected) and the resources store.refs #2937