Skip to content

Redesign tooltips#296

Merged
JammingBen merged 1 commit intomainfrom
feat/redesign-tooltip
Mar 7, 2025
Merged

Redesign tooltips#296
JammingBen merged 1 commit intomainfrom
feat/redesign-tooltip

Conversation

@JammingBen
Copy link
Copy Markdown
Member

@JammingBen JammingBen commented Mar 7, 2025

Redesigns the tooltips so they are a bit smaller and hide when leaving the root element.

image

fixes #295

Redesigns the tooltips so they are a bit smaller and hide when leaving the root element.
@JammingBen JammingBen self-assigned this Mar 7, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR redesigns tooltips to be smaller and to automatically hide when the root element is left.

  • Renames the export from ariaHidden to customProps and adds a CSS class for tooltips.
  • Adjusts the interactive property setting for tooltips.

Reviewed Changes

File Description
packages/design-system/src/directives/OcTooltip.ts Updated tooltip properties and plugin configuration for styling.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

packages/design-system/src/directives/OcTooltip.ts:26

  • [nitpick] Renaming from ariaHidden to customProps might reduce clarity about its functionality; consider a name that more explicitly reflects its role, such as tooltipAriaAttributes.
export const customProps = {

packages/design-system/src/directives/OcTooltip.ts:33

  • [nitpick] The addition of the 'oc-tooltip' class implies a change in styling conventions; ensure this naming aligns with the overall CSS naming strategy.
        instance.popper.classList.add('oc-tooltip')

packages/design-system/src/directives/OcTooltip.ts:65

  • Changing the interactive property from true to false alters the tooltip behavior significantly; please verify that the new behavior is intentional and aligns with the tooltip redesign.
      interactive: false,

@JammingBen JammingBen merged commit e7ffab1 into main Mar 7, 2025
@JammingBen JammingBen deleted the feat/redesign-tooltip branch March 7, 2025 14:32
@kulmann kulmann changed the title feat: redesign tooltips Redesign tooltips Mar 17, 2025
@openclouders openclouders mentioned this pull request Mar 17, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking on share tooltip starts sharing the wrong item

4 participants