Merged
Conversation
Redesigns the tooltips so they are a bit smaller and hide when leaving the root element.
Contributor
There was a problem hiding this comment.
PR Overview
This PR redesigns tooltips to be smaller and to automatically hide when the root element is left.
- Renames the export from ariaHidden to customProps and adds a CSS class for tooltips.
- Adjusts the interactive property setting for tooltips.
Reviewed Changes
| File | Description |
|---|---|
| packages/design-system/src/directives/OcTooltip.ts | Updated tooltip properties and plugin configuration for styling. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
packages/design-system/src/directives/OcTooltip.ts:26
- [nitpick] Renaming from ariaHidden to customProps might reduce clarity about its functionality; consider a name that more explicitly reflects its role, such as tooltipAriaAttributes.
export const customProps = {
packages/design-system/src/directives/OcTooltip.ts:33
- [nitpick] The addition of the 'oc-tooltip' class implies a change in styling conventions; ensure this naming aligns with the overall CSS naming strategy.
instance.popper.classList.add('oc-tooltip')
packages/design-system/src/directives/OcTooltip.ts:65
- Changing the interactive property from true to false alters the tooltip behavior significantly; please verify that the new behavior is intentional and aligns with the tooltip redesign.
interactive: false,
AlexAndBear
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesigns the tooltips so they are a bit smaller and hide when leaving the root element.
fixes #295