refactor: various components to script setup - #3041
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the migration of legacy Vue components/views across multiple OpenCloud Web packages from Options API / setup() { return ... } to Vue 3 <script setup> Composition API, aligning with the long-running refactor effort in #1462.
Changes:
- Converted multiple app views/components to
<script setup>and updated props/emits todefineProps/defineEmitspatterns. - Adjusted unit tests that accessed component instance internals (
wrapper.vm) to accommodate<script setup>typings. - Performed small composition-level refactors while preserving existing runtime behavior.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-app-webfinger/src/views/Resolve.vue | Migrates the resolve view to <script setup> while keeping discovery/redirect logic intact. |
| packages/web-app-search/tests/unit/views/List.spec.ts | Updates test VM access to work with <script setup> component instance typing. |
| packages/web-app-search/src/views/List.vue | Migrates list view to <script setup> and keeps search flow as composables/refs. |
| packages/web-app-preview/src/components/Sources/MediaAudio.vue | Migrates component to <script setup> and modernizes props/emits definitions. |
| packages/web-app-ocm/src/views/Wayf.vue | Migrates WAYF view to <script setup> with the same computed/handler logic. |
| packages/web-app-ocm/src/views/OutgoingInvitations.vue | Migrates view to <script setup> and keeps token listing/creation helpers. |
| packages/web-app-ocm/src/views/InvitationAcceptanceModal.vue | Migrates modal to <script setup> and switches to typed defineProps/defineEmits. |
| packages/web-app-ocm/src/views/IncomingInvitations.vue | Migrates view to <script setup> and retains decoding/acceptance flow. |
| packages/web-app-ocm/src/views/ConnectionsPanel.vue | Migrates panel to <script setup> with typed props and typed v-model emit. |
| packages/web-app-ocm/src/views/App.vue | Migrates OCM app shell to <script setup> and preserves polling/highlighting behavior. |
| packages/web-app-external/src/Redirect.vue | Migrates redirect view to <script setup> and keeps readiness-driven redirect logic. |
| packages/web-app-epub-reader/tests/unit/app.spec.ts | Updates test VM access to work with <script setup> component instance typing. |
| packages/web-app-epub-reader/src/App.vue | Migrates epub reader to <script setup> while preserving navigation/font size logic. |
| packages/web-app-app-store/src/views/AppList.vue | Migrates app list to <script setup> while keeping filter + highlighting behavior. |
| packages/web-app-app-store/src/views/AppDetails.vue | Migrates details view to <script setup> and keeps store-driven app lookup. |
| packages/web-app-app-store/src/LayoutContainer.vue | Migrates layout container to <script setup> and retains store-loading spinner gate. |
| packages/web-app-app-store/src/components/AppVersions.vue | Migrates versions table to <script setup>; keeps validation/mapping logic. |
| packages/web-app-app-store/src/components/AppTile.vue | Migrates tile to <script setup> and converts emits to typed defineEmits. |
| packages/web-app-app-store/src/components/AppTags.vue | Migrates tags to <script setup> and converts emits to typed defineEmits. |
| packages/web-app-app-store/src/components/AppResources.vue | Migrates resources list to <script setup> and keeps URL validation. |
| packages/web-app-app-store/src/components/AppImageGallery.vue | Migrates gallery to <script setup>; retains pagination/index behavior. |
| packages/web-app-app-store/src/components/AppAuthors.vue | Migrates authors list to <script setup> and keeps URL validation. |
| packages/web-app-app-store/src/components/AppActions.vue | Migrates actions menu to <script setup> and preserves action wiring. |
馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JammingBen
force-pushed
the
refactor/components-to-script-setup
branch
from
August 6, 2026 06:50
c6908c1 to
1a63a20
Compare
AlexAndBear
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #1462