Skip to content

refactor: various components to script setup - #3041

Merged
JammingBen merged 3 commits into
mainfrom
refactor/components-to-script-setup
Aug 7, 2026
Merged

refactor: various components to script setup#3041
JammingBen merged 3 commits into
mainfrom
refactor/components-to-script-setup

Conversation

@JammingBen

Copy link
Copy Markdown
Member

refs #1462

@JammingBen
JammingBen requested a lite review from Copilot August 5, 2026 12:41
@JammingBen JammingBen self-assigned this Aug 5, 2026
@JammingBen JammingBen added the Type:Maintenance E.g. technical debt, packaging, etc. label Aug 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the migration of legacy Vue components/views across multiple OpenCloud Web packages from Options API / setup() { return ... } to Vue 3 <script setup> Composition API, aligning with the long-running refactor effort in #1462.

Changes:

  • Converted multiple app views/components to <script setup> and updated props/emits to defineProps / defineEmits patterns.
  • Adjusted unit tests that accessed component instance internals (wrapper.vm) to accommodate <script setup> typings.
  • Performed small composition-level refactors while preserving existing runtime behavior.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/web-app-webfinger/src/views/Resolve.vue Migrates the resolve view to <script setup> while keeping discovery/redirect logic intact.
packages/web-app-search/tests/unit/views/List.spec.ts Updates test VM access to work with <script setup> component instance typing.
packages/web-app-search/src/views/List.vue Migrates list view to <script setup> and keeps search flow as composables/refs.
packages/web-app-preview/src/components/Sources/MediaAudio.vue Migrates component to <script setup> and modernizes props/emits definitions.
packages/web-app-ocm/src/views/Wayf.vue Migrates WAYF view to <script setup> with the same computed/handler logic.
packages/web-app-ocm/src/views/OutgoingInvitations.vue Migrates view to <script setup> and keeps token listing/creation helpers.
packages/web-app-ocm/src/views/InvitationAcceptanceModal.vue Migrates modal to <script setup> and switches to typed defineProps/defineEmits.
packages/web-app-ocm/src/views/IncomingInvitations.vue Migrates view to <script setup> and retains decoding/acceptance flow.
packages/web-app-ocm/src/views/ConnectionsPanel.vue Migrates panel to <script setup> with typed props and typed v-model emit.
packages/web-app-ocm/src/views/App.vue Migrates OCM app shell to <script setup> and preserves polling/highlighting behavior.
packages/web-app-external/src/Redirect.vue Migrates redirect view to <script setup> and keeps readiness-driven redirect logic.
packages/web-app-epub-reader/tests/unit/app.spec.ts Updates test VM access to work with <script setup> component instance typing.
packages/web-app-epub-reader/src/App.vue Migrates epub reader to <script setup> while preserving navigation/font size logic.
packages/web-app-app-store/src/views/AppList.vue Migrates app list to <script setup> while keeping filter + highlighting behavior.
packages/web-app-app-store/src/views/AppDetails.vue Migrates details view to <script setup> and keeps store-driven app lookup.
packages/web-app-app-store/src/LayoutContainer.vue Migrates layout container to <script setup> and retains store-loading spinner gate.
packages/web-app-app-store/src/components/AppVersions.vue Migrates versions table to <script setup>; keeps validation/mapping logic.
packages/web-app-app-store/src/components/AppTile.vue Migrates tile to <script setup> and converts emits to typed defineEmits.
packages/web-app-app-store/src/components/AppTags.vue Migrates tags to <script setup> and converts emits to typed defineEmits.
packages/web-app-app-store/src/components/AppResources.vue Migrates resources list to <script setup> and keeps URL validation.
packages/web-app-app-store/src/components/AppImageGallery.vue Migrates gallery to <script setup>; retains pagination/index behavior.
packages/web-app-app-store/src/components/AppAuthors.vue Migrates authors list to <script setup> and keeps URL validation.
packages/web-app-app-store/src/components/AppActions.vue Migrates actions menu to <script setup> and preserves action wiring.

馃挕 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/web-app-ocm/src/views/IncomingInvitations.vue
Comment thread packages/web-app-app-store/src/views/AppList.vue
Comment thread packages/web-app-search/src/views/List.vue
@JammingBen
JammingBen requested a review from AlexAndBear August 5, 2026 14:13
@JammingBen
JammingBen force-pushed the refactor/components-to-script-setup branch from c6908c1 to 1a63a20 Compare August 6, 2026 06:50
@JammingBen
JammingBen merged commit c422f7d into main Aug 7, 2026
30 checks passed
@JammingBen
JammingBen deleted the refactor/components-to-script-setup branch August 7, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type:Maintenance E.g. technical debt, packaging, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants