Skip to content

fix(design-system): avoid duplicated SVG ids - #3157

Merged
JammingBen merged 1 commit into
mainfrom
fix/svg-unique-ids
Aug 19, 2026
Merged

fix(design-system): avoid duplicated SVG ids#3157
JammingBen merged 1 commit into
mainfrom
fix/svg-unique-ids

Conversation

@JammingBen

@JammingBen JammingBen commented Aug 18, 2026

Copy link
Copy Markdown
Member

Avoid duplicated ids in SVGs by either redrawing them and removing their ids, or by passing a uniqueId param to the OcIcon component to ensure they stay unique and don't conflict.

@JammingBen JammingBen self-assigned this Aug 18, 2026
@JammingBen
JammingBen marked this pull request as draft August 18, 2026 14:57
@JammingBen

JammingBen commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

Converted to a draft for now - maybe we should just remove those ids from the SVGs.

Avoid duplicated ids in SVGs by either redrawing them and removing their
ids, or by passing a uniqueId param to the OcIcon component to ensure
they stay unique and don't conflict.
@JammingBen JammingBen changed the title fix(design-system): enforce unique ids for svgs fix(design-system): avoid duplicated SVG ids Aug 19, 2026
@JammingBen
JammingBen marked this pull request as ready for review August 19, 2026 05:20
@JammingBen
JammingBen merged commit a72b429 into main Aug 19, 2026
30 checks passed
@JammingBen
JammingBen deleted the fix/svg-unique-ids branch August 19, 2026 06:35
openclouders pushed a commit that referenced this pull request Aug 19, 2026
fix(design-system): avoid duplicated SVG ids
@openclouders openclouders mentioned this pull request Aug 19, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants