refactor!: drop mark.js - #3253
Merged
Merged
Conversation
Drop mark.js from the codebase and highlight via the new FilterHighlight
component. This has several advantages:
- Hardened highlighting; the old implementation had a few quirks where
highlighting would not work reliably (e.g. when entering a filter term
that yields results, then adding and removing random letters).
- Less boilerplate when using marks in components.
- Less external dependencies.
JammingBen
force-pushed
the
refactor/drop-mark-js
branch
from
August 28, 2026 07:37
ae4bc05 to
04a12b2
Compare
JammingBen
marked this pull request as ready for review
August 28, 2026 08:06
AlexAndBear
approved these changes
Aug 28, 2026
Member
|
LGTM, we could possibly move the FilterHighlight component to the design-system, no ? 馃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop
mark.jsfrom the codebase and highlight via the newFilterHighlightcomponent. This has several advantages:Breaking for developers
mark.jshas been removed: useFilterHighlight.vuefrom design-system instead.useFilterHighlighthas been removed: useFilterHighlight.vuefrom design-system instead.fixes #2966