Skip to content

fix: preserve lazy tile height - #3264

Merged
JammingBen merged 3 commits into
opencloud-eu:mainfrom
fredrikblau:fix/3170-match-lazy-tile-height
Aug 31, 2026
Merged

fix: preserve lazy tile height#3264
JammingBen merged 3 commits into
opencloud-eu:mainfrom
fredrikblau:fix/3170-match-lazy-tile-height

Conversation

@fredrikblau

Copy link
Copy Markdown
Contributor

Description

Lazy tile placeholders are shorter than hydrated tiles by the height of the tile content's line box. Revealing a tile therefore expands its grid row and shifts the items below it while scrolling.

Give the placeholder a minimum height based on the configured tile width, the 16:9 preview ratio, and the 44px content area used by hydrated tiles.

Related Issue

How Has This Been Tested?

  • test environment: Node.js 26.7.0, pnpm 11.24.0
  • test case 1: pnpm test:unit --run packages/web-pkg/tests/unit/components/FilesList/ResourceTile.spec.ts
  • test case 2: pnpm check:types
  • test case 3: pnpm lint
  • test case 4: pnpm format:check

Types of changes

  • Bugfix
  • Enhancement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt (improving code quality without changing functionality)
  • Tests (adding or updating tests)
  • Documentation (updates to the documentation, readme, or changelog)
  • Maintenance (updates to the build process or auxiliary tools and libraries)

Comment thread packages/web-pkg/src/components/FilesList/ResourceTile.vue Outdated
@fredrikblau

Copy link
Copy Markdown
Contributor Author

Updated as suggested: removed the calculated shimmer minimum height and changed the lazy tile bottom placeholder from h-6 to h-7.

Validated with the ResourceTile and ResourceTiles test suites (26 tests passed), formatting, ESLint, and diff checks.

@JammingBen JammingBen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JammingBen
JammingBen enabled auto-merge August 31, 2026 08:52
@JammingBen
JammingBen disabled auto-merge August 31, 2026 08:52
@JammingBen
JammingBen enabled auto-merge (squash) August 31, 2026 08:52
@JammingBen
JammingBen merged commit ccc6c3f into opencloud-eu:main Aug 31, 2026
32 checks passed
@openclouders openclouders mentioned this pull request Aug 31, 2026
1 task
openclouders pushed a commit that referenced this pull request Aug 31, 2026
* fix: define the shimmer animation start frame

* fix: preserve lazy tile height

---------

Co-authored-by: amir <mirammir21@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tiles view: lazy placeholder is 4px shorter than a hydrated tile, causing layout shift

3 participants