fix: preserve lazy tile height - #3264
Merged
JammingBen merged 3 commits intoAug 31, 2026
Merged
Conversation
7 tasks
JammingBen
requested changes
Aug 31, 2026
Contributor
Author
|
Updated as suggested: removed the calculated shimmer minimum height and changed the lazy tile bottom placeholder from h-6 to h-7. Validated with the ResourceTile and ResourceTiles test suites (26 tests passed), formatting, ESLint, and diff checks. |
JammingBen
enabled auto-merge
August 31, 2026 08:52
JammingBen
disabled auto-merge
August 31, 2026 08:52
JammingBen
enabled auto-merge (squash)
August 31, 2026 08:52
openclouders
pushed a commit
that referenced
this pull request
Aug 31, 2026
* fix: define the shimmer animation start frame * fix: preserve lazy tile height --------- Co-authored-by: amir <mirammir21@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Lazy tile placeholders are shorter than hydrated tiles by the height of the tile content's line box. Revealing a tile therefore expands its grid row and shifts the items below it while scrolling.
Give the placeholder a minimum height based on the configured tile width, the 16:9 preview ratio, and the 44px content area used by hydrated tiles.
Related Issue
How Has This Been Tested?
pnpm test:unit --run packages/web-pkg/tests/unit/components/FilesList/ResourceTile.spec.tspnpm check:typespnpm lintpnpm format:checkTypes of changes