Fix default Open action for .url files and add Text Editor support - #3266
Merged
Conversation
Member
Author
|
@kulmann this bug has likely been around for quite a while. It appears to have been introduced when we improved the On current main, That combination is an edge case coming from Also added text editor support because I just felt like it 馃槑 |
AlexAndBear
force-pushed
the
fix/url-open-default-handler
branch
from
August 29, 2026 20:09
e6171e5 to
04486af
Compare
AlexAndBear
force-pushed
the
fix/url-open-default-handler
branch
from
August 30, 2026 00:11
7303b28 to
ee6fd39
Compare
JammingBen
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this fix, clicking "Open" on a
.urlfile in the file-list context menu could result in no action at all.Root cause: the rendered action was treated as a route link as soon as a
routecallback existed, even when that callback returned no target. In that case, the handler-backed action ("Open shortcut") was never executed.What changed:
ActionMenuItem, route/href targets are resolved first.route(...)returns a concrete target..urlis now also registered for the Text Editor, so shortcut files can be opened as plain text via "Open with".Related Issue
How Has This Been Tested?
pnpm --filter @opencloud-eu/web-pkg check:typespnpm test:unit --run packages/web-pkg/tests/unit/components/ContextActions/ActionMenuItem.spec.tspnpm test:unit --run packages/web-app-text-editor/tests/unit/yjs.spec.ts packages/web-app-text-editor/tests/unit/app.spec.tsTypes of changes