Skip to content

Hide duplicate 'Insert from cloud' action in text editor toolbar - #3274

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/text-editor-hide-duplicate-cloud-insert-action
Sep 1, 2026
Merged

Hide duplicate 'Insert from cloud' action in text editor toolbar#3274
AlexAndBear merged 1 commit into
mainfrom
fix/text-editor-hide-duplicate-cloud-insert-action

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

This pull request removes the duplicate standalone Insert from cloud button from the text editor toolbar.

The cloud image action remains available where it belongs:

  • in the Insert image dropdown
  • in slash commands

This is done by setting showInToolbar: false on image-cloud.

Related Issue

  • Fixes N/A (no dedicated issue was provided)

How Has This Been Tested?

  • test environment: local development environment (macOS)
  • test case 1: pnpm test:unit --run packages/web-pkg/tests/unit/editor/composables/useEditorActions.spec.ts packages/web-pkg/tests/unit/editor/strategies/html.spec.ts packages/web-pkg/tests/unit/editor/strategies/markdown.spec.ts packages/web-pkg/tests/unit/editor/strategies/tiptapJson.spec.ts
  • test case 2: all targeted editor tests pass (4 files, 176 tests)

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear AlexAndBear self-assigned this Aug 31, 2026
@github-project-automation github-project-automation Bot moved this to Qualification in OpenCloud Team Board Aug 31, 2026
@AlexAndBear AlexAndBear moved this from Qualification to In Progress in OpenCloud Team Board Aug 31, 2026

@JammingBen JammingBen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hehe good catch

@AlexAndBear
AlexAndBear merged commit a2e1619 into main Sep 1, 2026
32 checks passed
@AlexAndBear
AlexAndBear deleted the fix/text-editor-hide-duplicate-cloud-insert-action branch September 1, 2026 07:03
@github-project-automation github-project-automation Bot moved this from In Progress to Done in OpenCloud Team Board Sep 1, 2026
@openclouders openclouders mentioned this pull request Sep 1, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants