Add a new attribute SAI_BFD_SESSION_ATTR_NEXT_HOP_ID to saibfd.h#2127
Conversation
|
/app run |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Skipping cap file sample.cap |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
you are causing enum shift: all attributes needs to be added at the end, also you need to force push to single commit all changes with enum shift |
Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com> remove extra space Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com> move new added attr to the end of enum Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
baorliu
force-pushed
the
baorliu_sh_bfd_use_nexthop
branch
from
3838d9d to
4fb9d00
Compare
|
updated and squashed old commits to a single commit. thanks |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2127 in repo opencomputeproject/SAI |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@baorliu - would you like to discuss this PR in this week's community meeting? |
in the middle of validating it in a system now. we can discuss it after I verify the use case with the new attributes. |
It is not targeting v1.16 for now. but if the proposal is approved, need to update it to different release. |
Hi @tjchadaga, we can discuss this PR in the community meeting, if there is any slot available this week or next week. I created a document to describe the use case: |
Scheduled for next week (3/6). |
| * @flags CREATE_ONLY | ||
| * @default false | ||
| */ | ||
| SAI_BFD_SESSION_ATTR_USE_NEXT_HOP, |
There was a problem hiding this comment.
Consider adding a VALID ONLY condition for SAI_BFD_SESSION_ATTR_DST_MAC_ADDRESS that it is valid only when SAI_BFD_SESSION_ATTR_USE_NEXT_HOP == false
There was a problem hiding this comment.
for the SAI_BFD_SESSION_ATTR_DST_MAC_ADDRESS, this is no validonly condition for SAI_BFD_SESSION_ATTR_HW_LOOKUP_VALID == true today.
If it is required for SAI_BFD_SESSION_ATTR_USE_NEXT_HOP == false, it can be added.
|
@JaiOCP - could you please help review? |
Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
5 participants
<re-created the PR, because the original one #2117 was using master branch in forked repo cause the commits were lost when do fork sync.
Please see comments in #2117 for review history>
Adding a new attribute SAI_BFD_SESSION_ATTR_NEXT_HOP_ID to saibfd.h to support forwarding single hop bfd packet to specific nexthop.
The proposed usage is:
1, this attribute can be provided both in create_bfd_session and set_bfd_session_attribute.
2, if SAI_BFD_SESSION_ATTR_USE_NEXT_HOP (optional, default is false) is set to true, BFD session will get next hop from SAI_BFD_SESSION_ATTR_NEXT_HOP_ID value and forward the bfd packet to the next hop. If SAI_BFD_SESSION_ATTR_USE_NEXT_HOP is false, attribute SAI_BFD_SESSION_ATTR_NEXT_HOP_ID will be ignored.
3, when using both SAI_BFD_SESSION_ATTR_HW_LOOKUP_VALID and SAI_BFD_SESSION_ATTR_USE_NEXT_HOP, the implementation is vender dependent.
A document to explain the use case for the proposed attributes:
sonic-net/SONiC#1932