HW FRR switchover notification support for protection groups #2269
Merged
tjchadaga merged 1 commit intoMay 19, 2026
Merged
Conversation
kcudnik
reviewed
Apr 2, 2026
Collaborator
|
To be discussed in SAI community. @tjchadaga |
sathk-marvell
approved these changes
Apr 21, 2026
chikkaiah-work
force-pushed
the
protection_grp_notification
branch
from
4202c6b to
21d0dce
Compare
Contributor
Author
|
@tjchadaga can you please help merge this ? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tjchadaga
requested changes
May 7, 2026
chikkaiah-work
force-pushed
the
protection_grp_notification
branch
2 times, most recently
from
ecf6555 to
c4fb6c0
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@tjchadaga can you approve this or you have more comments? |
Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com>
chikkaiah-work
force-pushed
the
protection_grp_notification
branch
from
09c78c2 to
47b2aa0
Compare
Contributor
Author
|
@tjchadaga, @kcudnik - Can we get this merged please ? |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tjchadaga
approved these changes
May 19, 2026
JaiOCP
added a commit
to JaiOCP/SAI
that referenced
this pull request
May 27, 2026
Signed-off-by: JaiOCP <jai.kumar@broadcom.com> SAI API performance monitoring Signed-off-by: JaiOCP <jai.kumar@broadcom.com> Fix gensairpc.pl crash on Doxygen 1.9.8+ by reusing NeedsTwoPassProcessing (opencomputeproject#2282) Why: To fix below build error Uncaught exception from user code: at gensairpc.pl line 480. main::assign_attr_types(HASH(0x55e190dc20c8), ARRAY(0x55e190d2d080)) called at gensairpc.pl line 434 main::get_definitions() called at gensairpc.pl line 156 main::assign_attr_types(HASH(0x55e190dc20c8), ARRAY(0x55e190d2d080)) called at gensairpc.pl line 434 main::get_definitions() called at gensairpc.pl line 156 How: gensairpc.pl crashed during SAI thrift build with an uncaught exception at line 480 (assign_attr_types) because its inline Doxygen layout detection was too weak - it only checked sai_8h.xml for any enumvalue presence, missing cases where the new Doxygen 1.9.8+ XML structure requires group__*.xml files to be processed for complete definitions. This caused incomplete parsing, leading to missing types and a croak in assign_attr_types when sai_attribute_value_t could not be found. Changes: - xmlutils.pm: Add NeedsTwoPassProcessing and export it. - parse.pl: Remove local NeedsTwoPassProcessing; use imported version. - gensairpc.pl: Replace inline detection with NeedsTwoPassProcessing() call, fixing the build failure and eliminating code duplication. Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com> Count BFD session state changes from UP to DOWN (opencomputeproject#2268) Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com> HW FRR switchover notification support for protection groups (opencomputeproject#2269) Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com> Port storm control enhancemnets (opencomputeproject#2258) (opencomputeproject#2258) Signed-off-by: rpmarvell <rperumal@marvell.com>
JaiOCP
pushed a commit
to JaiOCP/SAI
that referenced
this pull request
May 28, 2026
…puteproject#2269) Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com>
JaiOCP
added a commit
to JaiOCP/SAI
that referenced
this pull request
May 29, 2026
Signed-off-by: JaiOCP <jai.kumar@broadcom.com> OFH Support Signed-off-by: JaiOCP <jai.kumar@broadcom.com> Fix gensairpc.pl crash on Doxygen 1.9.8+ by reusing NeedsTwoPassProcessing (opencomputeproject#2282) Why: To fix below build error Uncaught exception from user code: at gensairpc.pl line 480. main::assign_attr_types(HASH(0x55e190dc20c8), ARRAY(0x55e190d2d080)) called at gensairpc.pl line 434 main::get_definitions() called at gensairpc.pl line 156 main::assign_attr_types(HASH(0x55e190dc20c8), ARRAY(0x55e190d2d080)) called at gensairpc.pl line 434 main::get_definitions() called at gensairpc.pl line 156 How: gensairpc.pl crashed during SAI thrift build with an uncaught exception at line 480 (assign_attr_types) because its inline Doxygen layout detection was too weak - it only checked sai_8h.xml for any enumvalue presence, missing cases where the new Doxygen 1.9.8+ XML structure requires group__*.xml files to be processed for complete definitions. This caused incomplete parsing, leading to missing types and a croak in assign_attr_types when sai_attribute_value_t could not be found. Changes: - xmlutils.pm: Add NeedsTwoPassProcessing and export it. - parse.pl: Remove local NeedsTwoPassProcessing; use imported version. - gensairpc.pl: Replace inline detection with NeedsTwoPassProcessing() call, fixing the build failure and eliminating code duplication. Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com> OFH Header Signed-off-by: JaiOCP <jai.kumar@broadcom.com> Count BFD session state changes from UP to DOWN (opencomputeproject#2268) Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com> HW FRR switchover notification support for protection groups (opencomputeproject#2269) Signed-off-by: Chikkegowda Chikkaiah <cchikkai@cisco.com> Port storm control enhancemnets (opencomputeproject#2258) (opencomputeproject#2258) Signed-off-by: rpmarvell <rperumal@marvell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added HW FRR switchover notification support for protection groups with a switch-level callback. The new callback reports switchover results per monitored object, including: monitored_oid,
switchover_success_count, and list protection groups that failed switchover. The callback is registered
through SAI_SWITCH_ATTR_NEXT_HOP_GROUP_HW_PROTECTION_SWITCHOVER_NOTIFY.