Skip to content

Add IDevID validation for Unary Bootz, and remove redundant interceptor.#347

Merged
Chounoki merged 1 commit into
openconfig:mainfrom
Chounoki:pr0
Jun 16, 2026
Merged

Add IDevID validation for Unary Bootz, and remove redundant interceptor.#347
Chounoki merged 1 commit into
openconfig:mainfrom
Chounoki:pr0

Conversation

@Chounoki

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the unused InterceptorOpts struct and associated logic from the server, and introduces IDevID certificate validation for both the GetBootstrapData and ReportStatus endpoints. The validateIDevID function has been refactored to support Unary Bootz by extracting peer certificates from the TLS context, as well as Streaming Bootz by manually validating the trust chain. The review feedback suggests adding a defensive nil check for the chassis parameter in validateIDevID to prevent potential nil pointer dereferences, and correcting a typo ('turst' to 'trust') in a code comment.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread server/service/service.go
Comment thread server/service/service.go Outdated
@Chounoki
Chounoki merged commit d4476e4 into openconfig:main Jun 16, 2026
12 checks passed
@Chounoki
Chounoki deleted the pr0 branch July 14, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants