Skip to content

Add error log for unsupported types before returning error.#356

Merged
Chounoki merged 1 commit into
openconfig:mainfrom
Chounoki:pr0
Jul 14, 2026
Merged

Add error log for unsupported types before returning error.#356
Chounoki merged 1 commit into
openconfig:mainfrom
Chounoki:pr0

Conversation

@Chounoki

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds error logging (log.Errorf) before returning gRPC status errors across multiple validation checks and default switch cases in server/service/service.go. The reviewer recommends removing these log statements because logging and returning an error simultaneously leads to duplicate log entries. Additionally, logging client-side input validation failures at the Error level can expose the server to log flooding and potential Denial of Service (DoS) attacks; such logging should instead be handled by top-level callers, gRPC interceptors, or downgraded to a debug level.

Comment thread server/service/service.go
Comment thread server/service/service.go
@Chounoki
Chounoki requested a review from gmacf July 14, 2026 04:39
@Chounoki
Chounoki merged commit 5c3baaa into openconfig:main Jul 14, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants