Add ipv6 support to bootz server.#358
Conversation
The ipv6 format uses colons, `:`, in the address so splitting on colon to find port does not work for ipv6 addresses. By adding port as a seperate config field, we can support ipv6 bootz server addresses.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request splits the server_address configuration field (previously formatted as "IP:port") into two distinct fields: server_address for the IP address and server_port for the port. This change is reflected in the configuration protobuf, server initialization logic, tests, and test configuration files. Additionally, several dependency versions in MODULE.bazel.lock were updated. Feedback on the changes suggests validating that server_port is not empty during server initialization to prevent binding to a random port.
The ipv6 format uses colons, `:`, in the address so splitting on colon to find port does not work for ipv6 addresses. By adding port as a separate config field, we can support ipv6 bootz server addresses.
Chounoki
left a comment
Chounoki
left a comment
There was a problem hiding this comment.
Could you also update this file?
https://github.com/openconfig/bootz/blob/main/test/config/bootz_config.textproto
|
Thanks for catching that. test/bootz_config.textproto should also be updated now. |
3 participants
The ipv6 format uses colons,
:, in the address so splitting on colon to find port does not work for ipv6 addresses. By adding port as a separate config field, we can support ipv6 bootz server addresses.