Optimize GenerateBootstrapData() to handle multiple serial numbers for the same chassis since they share the same bootstrap data.#360
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the GenerateBootstrapData method across the chassis manager and service layers to process a slice of serial numbers in a single call, replacing the previous parallelized errgroup approach. In the test suite, the mock implementation of GenerateBootstrapData was found to assign the same pointer to all elements of the returned slice. Because the service mutates these elements, this shared reference can lead to test interference and flaky tests. It is recommended to clone the mock response template for each element using proto.Clone.
gmacf
approved these changes
Jul 16, 2026
Chounoki
force-pushed
the
pr0
branch
2 times, most recently
from
July 16, 2026 05:05
57ec493 to
0e3b446
Compare
…r the same chassis since they share the same bootstrap data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.