Update telemetry_basic_check_test.go

[AmrNJ]

• Use gnmi.Watch instead of gnmi.Lookup to avoid errors seen by duplicate entries.
• Remove DSCP56 as it is reserved for Network control traffic and control plane is dropping the traffic due to rate limit.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the robustness of the telemetry basic check test by updating the data retrieval mechanism and refining the test traffic configuration. These changes ensure more stable test execution by addressing potential telemetry race conditions and avoiding conflicts with reserved network control traffic policies.

Highlights

• GNMI Telemetry Improvement: Replaced gnmi.Lookup with gnmi.Watch for MAC address retrieval to improve reliability and avoid errors caused by duplicate entries.
• Traffic Configuration Update: Removed DSCP 56 from the IPv4 flow configuration to prevent traffic drops, as this value is reserved for network control traffic and subject to rate limiting.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5834 / 774fbe8

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		gNMI-1.10: Telemetry: Basic Check	2d1f3c1c	Log
Cisco 8000E		gNMI-1.10: Telemetry: Basic Check	5acf6d49	Log
Cisco XRd		gNMI-1.10: Telemetry: Basic Check	35099fb8	Log
Juniper ncPTX		gNMI-1.10: Telemetry: Basic Check	2b00c485	Log
Nokia SR Linux		gNMI-1.10: Telemetry: Basic Check	d337af2c	Log
Openconfig Lemming		gNMI-1.10: Telemetry: Basic Check	a1f5dfeb	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		gNMI-1.10: Telemetry: Basic Check
Cisco 8808		gNMI-1.10: Telemetry: Basic Check
Juniper PTX10008		gNMI-1.10: Telemetry: Basic Check
Nokia 7250 IXR-10e		gNMI-1.10: Telemetry: Basic Check

Help

[gemini-code-assist]

Code Review

This pull request updates the telemetry basic check test to use gnmi.Watch instead of gnmi.Lookup for retrieving an interface's MAC address, and removes a DSCP PHB configuration from an IPv4 flow. The review feedback recommends enhancing the robustness of the gnmi.Watch condition by verifying that the retrieved MAC address is both present and non-empty to avoid transient uninitialized states.

[gemini-code-assist]

To ensure robustness and follow defensive programming practices, the watch condition should verify that the retrieved MAC address is not only present but also non-empty. Some devices might transiently report an empty string or uninitialized state when the interface is first configured, which would satisfy v.IsPresent() but result in an invalid MAC address being returned.

val, ok := gnmi.Watch(t, dut.GNMIOpts().WithYGNMIOpts(opts...), gnmi.OC().Interface(intfName).Ethernet().MacAddress().State(), time.Minute, func(v *ygnmi.Value[string]) bool {
		val, present := v.Val()
		return present && val != ""
	}).Await(t)