platform: Add missing integrated-circuit resource state paths to utilization_test README - #5857
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation for the integrated circuit utilization test to accurately reflect the telemetry paths covered. By adding these specific resource state paths, the README now correctly documents the OpenConfig coverage for these parameters. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the README.md for the integrated circuit utilization test by adding several new state paths. However, the reviewer noted that the threshold-related paths (used-threshold-upper, used-threshold-upper-clear, and used-threshold-upper-exceeded) do not exist in the OpenConfig integrated-circuit model at this location and should be removed.
…ate paths to utilization_test README Add Canonical OC JSON representation for system resource threshold configuration and document OpenConfig telemetry coverage for max-limit, used-threshold-upper, used-threshold-upper-clear, and used-threshold-upper-exceeded in feature/platform/integrated_circuit/otg_tests/utilization_test/README.md.
94886ee to
c6aed46
Compare
Document OpenConfig coverage for max-limit, used-threshold-upper, used-threshold-upper-clear, and used-threshold-upper-exceeded under telemetry parameter coverage in feature/platform/integrated_circuit/otg_tests/utilization_test/README.md.