Skip to content

platform: Add missing integrated-circuit resource state paths to utilization_test README - #5857

Open
singhavnish2516 wants to merge 2 commits into
openconfig:mainfrom
singhavnish2516:platform/add_ic_utilization_resources_readme_paths
Open

platform: Add missing integrated-circuit resource state paths to utilization_test README#5857
singhavnish2516 wants to merge 2 commits into
openconfig:mainfrom
singhavnish2516:platform/add_ic_utilization_resources_readme_paths

Conversation

@singhavnish2516

Copy link
Copy Markdown
Contributor

Document OpenConfig coverage for max-limit, used-threshold-upper, used-threshold-upper-clear, and used-threshold-upper-exceeded under telemetry parameter coverage in feature/platform/integrated_circuit/otg_tests/utilization_test/README.md.

@singhavnish2516
singhavnish2516 requested a review from a team as a code owner August 8, 2026 06:48
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for the integrated circuit utilization test to accurately reflect the telemetry paths covered. By adding these specific resource state paths, the README now correctly documents the OpenConfig coverage for these parameters.

Highlights

  • Documentation Update: Added missing OpenConfig telemetry paths to the utilization_test README.
  • Resource State Coverage: Included max-limit, used-threshold-upper, used-threshold-upper-clear, and used-threshold-upper-exceeded in the documentation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md for the integrated circuit utilization test by adding several new state paths. However, the reviewer noted that the threshold-related paths (used-threshold-upper, used-threshold-upper-clear, and used-threshold-upper-exceeded) do not exist in the OpenConfig integrated-circuit model at this location and should be removed.

…ate paths to utilization_test README

Add Canonical OC JSON representation for system resource threshold configuration and document OpenConfig telemetry coverage for max-limit, used-threshold-upper, used-threshold-upper-clear, and used-threshold-upper-exceeded in feature/platform/integrated_circuit/otg_tests/utilization_test/README.md.
@singhavnish2516
singhavnish2516 force-pushed the platform/add_ic_utilization_resources_readme_paths branch from 94886ee to c6aed46 Compare August 8, 2026 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants