Update juniper to restart session.#719
Closed
kraney wants to merge 1 commit into
Closed
Conversation
There's a potential race when there's a schema change, that leaves a session broken. In this case, Juniper outputs "Restart session and try again." The existing code tries again, but without restarting the session. So it is doomed to just fail again. This change notices the condition and restarts the session if it occurs. In theory that should help. This is intended to unblock PR openconfig#717, so may need to merge in front of that one.
Contributor
Author
|
Withdrawing this because it did not, in fact, improve the result. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a potential race when there's a schema change, that leaves a session broken. In this case, Juniper outputs "Restart session and try again."
The existing code tries again, but without restarting the session. So it is doomed to just fail again. This change notices the condition and restarts the session if it occurs. In theory that should help.
This is intended to unblock PR #717, so may need to merge in front of that one.