Skip to content
This repository was archived by the owner on Jul 18, 2023. It is now read-only.

Update definitions-terms.md#64

Merged
SteveLasker merged 1 commit into
opencontainers:mainfrom
Zhurik:patch-1
May 25, 2023
Merged

Update definitions-terms.md#64
SteveLasker merged 1 commit into
opencontainers:mainfrom
Zhurik:patch-1

Conversation

@Zhurik
Copy link
Copy Markdown
Contributor

@Zhurik Zhurik commented May 17, 2023

typo

@imjasonh
Copy link
Copy Markdown
Member

Both of these spellings seem to be accepted as correct in common usage. I'm not sure this change is worth making.

@Zhurik
Copy link
Copy Markdown
Contributor Author

Zhurik commented May 17, 2023

Both of these spellings seem to be accepted as correct in common usage. I'm not sure this change is worth making.

The only problem is this link leads to page that doesn't exist. So I decided to match word with link

Copy link
Copy Markdown
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and the PR @Zhurik
There’s a few threads on the o vs e : https://internals.rust-lang.org/t/spelling-bikeshed-implementor-or-implementer/16926

If you’d like to match the filename to use implementers.md we could merge that change.

Copy link
Copy Markdown

@sudo-bmitch sudo-bmitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementer appears to be the correct term: https://dictionary.cambridge.org/us/dictionary/english/implementer

I think the filename change makes more sense. And the link to the file needs to match the usage of the link and the filename itself.

Comment thread definitions-terms.md Outdated
## Registry

A registry, or container registry, is an instance of the [distribution-spec]. See [Implementers][implementers] for a list of registries that support OCI Artifacts.
A registry, or container registry, is an instance of the [distribution-spec]. See [Implementors][implementors] for a list of registries that support OCI Artifacts.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A registry, or container registry, is an instance of the [distribution-spec]. See [Implementors][implementors] for a list of registries that support OCI Artifacts.
A registry, or container registry, is an instance of the [distribution-spec]. See [Implementers][implementers] for a list of registries that support OCI Artifacts.

This reverts most of this change, except the part that makes the link line up with the link listed at the bottom.

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls rename the file :)

Copy link
Copy Markdown
Contributor

@SteveLasker SteveLasker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Zhurik
Appreciate the changes
LGTM
Steve

Comment thread definitions-terms.md
## Registry

A registry, or container registry, is an instance of the [distribution-spec]. See [Implementers][implementers] for a list of registries that support OCI Artifacts.
A registry, or container registry, is an instance of the [distribution-spec]. See [Implementers](implementers.md) for a list of registries that support OCI Artifacts.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

believe it or not the typical pattern for linking to the bottom of the md is [][]

though linking directly the file with () also works might as well use the redirection to below

Suggested change
A registry, or container registry, is an instance of the [distribution-spec]. See [Implementers](implementers.md) for a list of registries that support OCI Artifacts.
A registry, or container registry, is an instance of the [distribution-spec]. See [Implementers][implementers] for a list of registries that support OCI Artifacts.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zhurik, we appreciate the effort for the PR. If the additional tweaks are too much detail, we can merge this as is, and tweak a bit further as the link works with your PR. We just have a dangling entry in the links section at the bottom of the file.

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM we can fix the reference to link at bot of file in another commit.. cheers

@SteveLasker
Copy link
Copy Markdown
Contributor

Hi @Zhurik,
We can do the link fix post merge, however, unfortunately, we need a signature associated with your PR
See: https://github.com/opencontainers/artifacts/blob/main/CONTRIBUTING.md#sign-your-work for OCI Contributing guidelines.

And the DCO fix:
See https://github.com/opencontainers/artifacts/pull/64/checks?check_run_id=13574434672

git config --global user.name "full name here"
git config --global user.email "email address here" 
git commit -s --amend

Signed-off-by: Zhuravlev Alexander <alex15023@yandex.ru>
@Zhurik
Copy link
Copy Markdown
Contributor Author

Zhurik commented May 25, 2023

Hi @Zhurik, We can do the link fix post merge, however, unfortunately, we need a signature associated with your PR See: https://github.com/opencontainers/artifacts/blob/main/CONTRIBUTING.md#sign-your-work for OCI Contributing guidelines.

And the DCO fix: See https://github.com/opencontainers/artifacts/pull/64/checks?check_run_id=13574434672

git config --global user.name "full name here"
git config --global user.email "email address here" 
git commit -s --amend

Done

@SteveLasker SteveLasker merged commit c7d6287 into opencontainers:main May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants