Update definitions-terms.md#64
Conversation
|
Both of these spellings seem to be accepted as correct in common usage. I'm not sure this change is worth making. |
The only problem is this link leads to page that doesn't exist. So I decided to match word with link |
SteveLasker
left a comment
There was a problem hiding this comment.
Thanks for the catch and the PR @Zhurik
There’s a few threads on the o vs e : https://internals.rust-lang.org/t/spelling-bikeshed-implementor-or-implementer/16926
If you’d like to match the filename to use implementers.md we could merge that change.
There was a problem hiding this comment.
Implementer appears to be the correct term: https://dictionary.cambridge.org/us/dictionary/english/implementer
I think the filename change makes more sense. And the link to the file needs to match the usage of the link and the filename itself.
| ## Registry | ||
|
|
||
| A registry, or container registry, is an instance of the [distribution-spec]. See [Implementers][implementers] for a list of registries that support OCI Artifacts. | ||
| A registry, or container registry, is an instance of the [distribution-spec]. See [Implementors][implementors] for a list of registries that support OCI Artifacts. |
There was a problem hiding this comment.
| A registry, or container registry, is an instance of the [distribution-spec]. See [Implementors][implementors] for a list of registries that support OCI Artifacts. | |
| A registry, or container registry, is an instance of the [distribution-spec]. See [Implementers][implementers] for a list of registries that support OCI Artifacts. |
This reverts most of this change, except the part that makes the link line up with the link listed at the bottom.
SteveLasker
left a comment
There was a problem hiding this comment.
Thank you, @Zhurik
Appreciate the changes
LGTM
Steve
| ## Registry | ||
|
|
||
| A registry, or container registry, is an instance of the [distribution-spec]. See [Implementers][implementers] for a list of registries that support OCI Artifacts. | ||
| A registry, or container registry, is an instance of the [distribution-spec]. See [Implementers](implementers.md) for a list of registries that support OCI Artifacts. |
There was a problem hiding this comment.
believe it or not the typical pattern for linking to the bottom of the md is [][]
though linking directly the file with () also works might as well use the redirection to below
| A registry, or container registry, is an instance of the [distribution-spec]. See [Implementers](implementers.md) for a list of registries that support OCI Artifacts. | |
| A registry, or container registry, is an instance of the [distribution-spec]. See [Implementers][implementers] for a list of registries that support OCI Artifacts. |
There was a problem hiding this comment.
@Zhurik, we appreciate the effort for the PR. If the additional tweaks are too much detail, we can merge this as is, and tweak a bit further as the link works with your PR. We just have a dangling entry in the links section at the bottom of the file.
mikebrow
left a comment
There was a problem hiding this comment.
/LGTM we can fix the reference to link at bot of file in another commit.. cheers
|
Hi @Zhurik, And the DCO fix: |
Signed-off-by: Zhuravlev Alexander <alex15023@yandex.ru>
Done |
typo