Show error stack trace if --debug is given#2789
Merged
AkihiroSuda merged 1 commit intoopencontainers:masterfrom Feb 5, 2021
Merged
Show error stack trace if --debug is given#2789AkihiroSuda merged 1 commit intoopencontainers:masterfrom
AkihiroSuda merged 1 commit intoopencontainers:masterfrom
Conversation
We use github.com/pkg/errors to produce an error in many places. One of its benefits is error comes with a stack trace. Let's print that stack trace if --debug is set. Example: # ../runc --debug run -d '' ERRO[0000] container id cannot be empty DEBU[0000] container id cannot be empty main.init github.com/opencontainers/runc/utils_linux.go:28 runtime.doInit runtime/proc.go:5652 runtime.main runtime/proc.go:191 runtime.goexit runtime/asm_amd64.s:1374 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This was referenced Feb 4, 2021
cyphar
approved these changes
Feb 5, 2021
Member
cyphar
left a comment
cyphar
left a comment
There was a problem hiding this comment.
LGTM. I'm kinda surprised we weren't doing this already.
AkihiroSuda
approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use github.com/pkg/errors to produce an error in many places.
One of its benefits is error comes with a stack trace.
Let's print that stack trace if --debug is given.
Example: