[1.2] CHANGELOG: v1.2.6 formatting fixes

[kolyshkin]

Fix headers

[rata]

LGTM.

I'm surprised how this happened, I thought I c&p it. but clearly I missed something. Sorry!

[kolyshkin]

LGTM.

I'm surprised how this happened, I thought I c&p it. but clearly I missed something. Sorry!

You are not alone -- me and other reviewers of #4674 missed it, too.

[lifubang]

There is also a small format issue in v1.2.5, but it has no influence on rendering html:
https://github.com/opencontainers/runc/pull/4683/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR39

[kolyshkin]

There is also a small format issue in v1.2.5, but it has no influence on rendering html: https://github.com/opencontainers/runc/pull/4683/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR39

There are many more like this in 1.1.x (grep '^\* ' CHANGELOG.md), but apparently github markdown list documentation doesn't tell anything about a preceding space. I also checked the more formal spec https://github.github.com/gfm/#list-items and it appears it's OK both ways.

Albeit other markdown formatters might require no space before the list elements.

Maybe we need some sort of a linter for md files. Problem is, there are many variations of markdown available, and github seems to be one of the most forgiving.

@lifubang I'm going to leave v1.2.5 issue as is for now and will look into how to improve the situation overall without introducing too restrictive linters.

[cyphar]

I personally prefer having a space before * and that's how I usually write markdown (I prefer how it looks visually when reading the text file), but if we want to add a linter that disallows that I don't particularly mind.

[kolyshkin]

I personally prefer having a space before * and that's how I usually write markdown (I prefer how it looks visually when reading the text file), but if we want to add a linter that disallows that I don't particularly mind.

Most of our code uses ␣* (i.e. a space before *), and we don't use those .md files as input for any other converters, so it doesn't really matter.