libct/int: better error reporting#5232
Merged
rata merged 5 commits intoopencontainers:mainfrom Apr 15, 2026
Merged
Conversation
kolyshkin
force-pushed
the
int-wait-stderr
branch
from
7bfdeff to
2559bd5
Compare
rata
reviewed
Apr 13, 2026
Member
rata
left a comment
rata
left a comment
There was a problem hiding this comment.
This overall LGTM, left a simple comment about a typo pi vs pid that is fixed later in another commit.
Open
Since Wait returns an ExitError if process' exit status is not 0, checking process status is redundant and this code is never reached. Remove it. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
When running a process inside a container, make sure its stderr is not nil (except for some trivial cases like cat). Modify waitProcess to show failed command's stderr, if possible. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
By default, readlink is silent about any errors. Make it verbose so we can better interpret any test failures. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
It is never used. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The latter is simpler and provides just enough functionality to be used here. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
force-pushed
the
int-wait-stderr
branch
from
2559bd5 to
9970cbf
Compare
lifubang
approved these changes
Apr 15, 2026
kolyshkin
added
the
backport/1.5-todo
kolyshkin
added
backport/1.5-done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saw the following failure (from here):
It looks like we're running commands and expect them to exit(0), but when they fail we have no way of knowing what went wrong.
Address this by showing process' stderr if something bad happens.
While at it,
Related to #5245