Skip to content

Complete migration from Cirrus CI to GHA (Lima)#5239

Merged
rata merged 1 commit intoopencontainers:mainfrom
AkihiroSuda:lima-actions
Apr 16, 2026
Merged

Complete migration from Cirrus CI to GHA (Lima)#5239
rata merged 1 commit intoopencontainers:mainfrom
AkihiroSuda:lima-actions

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

Fix #5238

@AkihiroSuda AkihiroSuda added this to the 1.5.0 milestone Apr 12, 2026
@AkihiroSuda AkihiroSuda added backport/1.3-todo A PR in main branch which needs to be backported to release-1.3 backport/1.4-todo A PR in main branch which needs to backported to release-1.4 labels Apr 12, 2026
@AkihiroSuda AkihiroSuda marked this pull request as draft April 12, 2026 08:02
@AkihiroSuda AkihiroSuda force-pushed the lima-actions branch 6 times, most recently from 8b8652d to ebc1ce3 Compare April 12, 2026 09:16
@AkihiroSuda AkihiroSuda removed the backport/1.3-todo A PR in main branch which needs to be backported to release-1.3 label Apr 12, 2026
@AkihiroSuda AkihiroSuda force-pushed the lima-actions branch 4 times, most recently from 4c57430 to e19b112 Compare April 12, 2026 17:55
@AkihiroSuda AkihiroSuda marked this pull request as ready for review April 12, 2026 18:20
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This part seems missing from the setup_host script:
# Allow potentially unsafe tests.
echo 'export RUNC_ALLOW_UNSAFE_TESTS=yes' >> /root/.bashrc

I realize it was also missing from setup_host_fedora, too, but it was in cirrus.yml. See #5212 for motivation.

  1. This part is missing:
# To avoid "avc: denied { nosuid_transition }" from SELinux as we run tests on /tmp. 
mount -o remount,suid /tmp

Do we have selinux off in fedora lima template? Or is this no longer required?

Comment thread .github/workflows/test.yml Outdated
Comment thread script/setup_host.sh
@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Apr 13, 2026

echo 'export RUNC_ALLOW_UNSAFE_TESTS=yes' >> /root/.bashrc

Added

Do we have selinux off in fedora lima template?

On.

https://github.com/opencontainers/runc/actions/runs/24313386479/job/70988120894?pr=5239

+ lima sestatus
SELinux status:                 enabled
SELinuxfs mount:                /sys/fs/selinux
SELinux root directory:         /etc/selinux
Loaded policy name:             targeted
Current mode:                   enforcing
Mode from config file:          enforcing
Policy MLS status:              enabled
Policy deny_unknown status:     allowed
Memory protection checking:     actual (secure)
Max kernel policy version:      35

Or is this no longer required?

Apparently no longer required

@AkihiroSuda AkihiroSuda force-pushed the lima-actions branch 2 times, most recently from 67d1562 to 19493bf Compare April 13, 2026 06:02
Copy link
Copy Markdown
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! It mostly LGTM, left some simple comments

Comment thread script/setup_host.sh Outdated
Comment thread .github/workflows/test.yml Outdated
Comment thread script/setup_host.sh Outdated
@AkihiroSuda AkihiroSuda force-pushed the lima-actions branch 2 times, most recently from d6e7665 to 0e3ef95 Compare April 14, 2026 09:28
Fix issue 5238

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kolyshkin kolyshkin added the backport/1.5-todo A PR in main branch which needs to be backported to release-1.5 label Apr 14, 2026
@kolyshkin
Copy link
Copy Markdown
Contributor

Not sure if we need the 1.3 backport; most probably we'll still make one more 1.3.x, so I guess we have to. Adding the label.

@kolyshkin kolyshkin added the backport/1.3-todo A PR in main branch which needs to be backported to release-1.3 label Apr 14, 2026
@kolyshkin kolyshkin requested review from cyphar and rata April 14, 2026 21:38
Comment thread script/setup_host.sh
@kolyshkin kolyshkin requested a review from rata April 15, 2026 21:59
Copy link
Copy Markdown
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rata
Copy link
Copy Markdown
Member

rata commented Apr 16, 2026

The cirrus CI is ofc not running, so that means to merge I need to bypass the rules. I'll do it, as I think it's the only way out of this

@rata rata merged commit 51d0c94 into opencontainers:main Apr 16, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.3-todo A PR in main branch which needs to be backported to release-1.3 backport/1.4-todo A PR in main branch which needs to backported to release-1.4 backport/1.5-todo A PR in main branch which needs to be backported to release-1.5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate Cirrus CI jobs to GHA before June 1st

3 participants