Complete migration from Cirrus CI to GHA (Lima)#5239
Complete migration from Cirrus CI to GHA (Lima)#5239rata merged 1 commit intoopencontainers:mainfrom
Conversation
3c4b115 to
c240923
Compare
8b8652d to
ebc1ce3
Compare
4c57430 to
e19b112
Compare
e19b112 to
96f0b4c
Compare
kolyshkin
left a comment
There was a problem hiding this comment.
- This part seems missing from the setup_host script:
# Allow potentially unsafe tests.
echo 'export RUNC_ALLOW_UNSAFE_TESTS=yes' >> /root/.bashrcI realize it was also missing from setup_host_fedora, too, but it was in cirrus.yml. See #5212 for motivation.
- This part is missing:
# To avoid "avc: denied { nosuid_transition }" from SELinux as we run tests on /tmp.
mount -o remount,suid /tmpDo we have selinux off in fedora lima template? Or is this no longer required?
Added
On. https://github.com/opencontainers/runc/actions/runs/24313386479/job/70988120894?pr=5239 + lima sestatus
SELinux status: enabled
SELinuxfs mount: /sys/fs/selinux
SELinux root directory: /etc/selinux
Loaded policy name: targeted
Current mode: enforcing
Mode from config file: enforcing
Policy MLS status: enabled
Policy deny_unknown status: allowed
Memory protection checking: actual (secure)
Max kernel policy version: 35
Apparently no longer required |
67d1562 to
19493bf
Compare
rata
left a comment
There was a problem hiding this comment.
Thanks for tackling this! It mostly LGTM, left some simple comments
d6e7665 to
0e3ef95
Compare
Fix issue 5238 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
0e3ef95 to
9d697a9
Compare
|
Not sure if we need the 1.3 backport; most probably we'll still make one more 1.3.x, so I guess we have to. Adding the label. |
|
The cirrus CI is ofc not running, so that means to merge I need to bypass the rules. I'll do it, as I think it's the only way out of this |
Fix #5238