ci: switch build scripts from wget to curl#5260
Open
alliasgher wants to merge 1 commit intoopencontainers:mainfrom
Open
ci: switch build scripts from wget to curl#5260alliasgher wants to merge 1 commit intoopencontainers:mainfrom
alliasgher wants to merge 1 commit intoopencontainers:mainfrom
Conversation
kolyshkin
reviewed
Apr 23, 2026
alliasgher
force-pushed
the
chore/5240-unify-curl
branch
from
be3d2ea to
479513b
Compare
alliasgher
changed the title
Contributor
|
A single comment about wget in Dockerfile; the rest LGTM. |
runc's build scripts and CI setup used a mix of wget (4 sites) and
curl (8 sites) for HTTPS fetches. Standardise the three script sites on
curl, which is already required by the majority of call sites.
* script/build-libpathrs.sh and script/build-seccomp.sh: replace
wget "<url>"{,.asc} with curl -fsSLO "<url>"{,.asc}. Bash brace
expansion still yields two separate downloads (the tarball and its
.asc signature).
* script/setup_host.sh: replace wget with curl in the Fedora RPM
install list.
Leaving the single wget call in Dockerfile untouched per review
feedback -- the trixie base image already ships wget, and switching
would add an extra apt-get update && install step before the existing
single-pass package install.
Refs opencontainers#5240
Signed-off-by: Ali <alliasgher123@gmail.com>
alliasgher
force-pushed
the
chore/5240-unify-curl
branch
from
479513b to
40f5fbd
Compare
Author
|
Force-pushed 40f5fbd: fixed a second bug CI caught — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
runc's build scripts and Dockerfile use a mix of
wget(4 sites) andcurl(8 sites) for HTTPS fetches. Per #5240, standardise oncurl— it's already used in the majority of sites and is available on both Debian and Fedora base images runc builds against.Changes
Dockerfile— replace thewget -nv $CRIU_REPO/Release.keystep withcurl -fsSL. Thegolang:<version>-trixiebase image doesn't ship curl (per @eschmechel's caveat on the issue), so install it andca-certificatesvia a small dedicatedapt-get installstep before the key fetch. Dropped the now-redundant standalonecurlfrom the subsequent package list.script/build-libpathrs.shandscript/build-seccomp.sh— replacewget "<url>"{,.asc}withcurl -fsSLO "<url>"{,.asc}. Bash brace expansion still yields two separate downloads (of the tarball and its.ascsignature).script/setup_host.sh— replacewgetwithcurlin the RPM install list so Fedora hosts get curl installed instead.After this PR,
grep -r wget script Dockerfileis empty.Testing
wgetreferences remain underscript/, Dockerfiles, or.github/workflows.bash -nparses all three modified shell scripts cleanly.Closes #5240