Create unique session key name for every container#582
Merged
mrunalp merged 1 commit intoopencontainers:masterfrom Feb 26, 2016
Merged
Create unique session key name for every container#582mrunalp merged 1 commit intoopencontainers:masterfrom
mrunalp merged 1 commit intoopencontainers:masterfrom
Conversation
Member
|
Curious... what is the significance of the 12 chars as the trunc point for the |
Contributor
Author
|
@mikebrow DOS times are over. :-) The truncation relates to the ID of containers being used in docker where every container seems to be distinguishable by 12 hex-digits. |
Member
|
Ok thx... 12 just seems random... But it makes sense to align with docker's chosen number ffff ffff ffff hmm. Cheers! |
Member
|
Since this is a security feature, I'd prefer that we used the same length as the container IDs (so you will get a collision with one or the other at about the same time). |
stefanberger
force-pushed
the
new_session_keyring
branch
from
e75abe9 to
3741133
Compare
Create a unique session key name for every container. Use the pattern _ses.<postfix> with postfix being the container's Id. This patch does not prevent containers from joining each other's session keyring. Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
stefanberger
force-pushed
the
new_session_keyring
branch
from
3741133 to
5fbf791
Compare
Contributor
Author
|
Updated to use full Id of container. |
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
mrunalp
pushed a commit
that referenced
this pull request
Feb 26, 2016
Create unique session key name for every container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a unique session key name for every container. Use the pattern
_ses. with postfix being maximum 12 characters of the container's
Id.
This patch does not prevent containers from joining each other's session
keyring.
Signed-off-by: Stefan Berger stefanb@linux.vnet.ibm.com