Version 1.20260708.1#574
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps the project version and extends the existing Linux/glibc compatibility shim used by the Python bindings to also cover the unsigned C23 string-to-integer conversion entry points introduced in newer glibc versions.
Changes:
- Bump
VERSION.txtfrom1.20260708.0to1.20260708.1. - Extend
src/bindings/python/glibc.cppto provide weak wrappers for__isoc23_strtoul()and__isoc23_strtoull()in addition to the existing__isoc23_strtol()and__isoc23_strtoll(). - Update the Python bindings CMake logic to detect the additional
__isoc23_*symbols and skip compiling the shim when all are available.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| VERSION.txt | Version bump to 1.20260708.1. |
| src/bindings/python/glibc.cpp | Adds weak wrappers for __isoc23_strtoul/__isoc23_strtoull to match glibc 2.38+ symbol expectations. |
| src/bindings/python/CMakeLists.txt | Adds symbol checks for the unsigned __isoc23_* functions and updates the condition for excluding glibc.cpp. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.