Skip to content

Version 1.20260708.1#574

Merged
agarny merged 2 commits into
opencor:mainfrom
agarny:cleaning-up
Jul 8, 2026
Merged

Version 1.20260708.1#574
agarny merged 2 commits into
opencor:mainfrom
agarny:cleaning-up

Conversation

@agarny

@agarny agarny commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings July 8, 2026 01:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the project version and extends the existing Linux/glibc compatibility shim used by the Python bindings to also cover the unsigned C23 string-to-integer conversion entry points introduced in newer glibc versions.

Changes:

  • Bump VERSION.txt from 1.20260708.0 to 1.20260708.1.
  • Extend src/bindings/python/glibc.cpp to provide weak wrappers for __isoc23_strtoul() and __isoc23_strtoull() in addition to the existing __isoc23_strtol() and __isoc23_strtoll().
  • Update the Python bindings CMake logic to detect the additional __isoc23_* symbols and skip compiling the shim when all are available.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
VERSION.txt Version bump to 1.20260708.1.
src/bindings/python/glibc.cpp Adds weak wrappers for __isoc23_strtoul/__isoc23_strtoull to match glibc 2.38+ symbol expectations.
src/bindings/python/CMakeLists.txt Adds symbol checks for the unsigned __isoc23_* functions and updates the condition for excluding glibc.cpp.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@agarny agarny merged commit b0fbdca into opencor:main Jul 8, 2026
24 checks passed
@agarny agarny deleted the cleaning-up branch July 8, 2026 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants