Version 1.20260708.2#575
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps the project version and extends the Python bindings’ glibc-compat layer to cover additional glibc symbols (notably arc4random*) needed for building manylinux-targeted wheels with newer prebuilt toolchains. It also substantially changes CI/CD workflow execution by commenting out most jobs and enabling the CD workflow on pull requests.
Changes:
- Bump
VERSION.txtfrom1.20260708.1to1.20260708.2. - Add glibc compatibility wrappers for
arc4random,arc4random_buf, andarc4random_uniform, and update CMake symbol checks to conditionally compile the wrapper TU. - Comment out most CI/CD jobs (leaving a much narrower set active) and add
pull_requesttriggering to CD.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| VERSION.txt | Updates the project version number. |
| src/bindings/python/glibc.cpp | Adds weak glibc compatibility wrappers, including arc4random*. |
| src/bindings/python/CMakeLists.txt | Extends symbol detection logic to include arc4random* and conditionally drop glibc.cpp. |
| .github/workflows/ci.yml | Comments out most CI matrix entries and disables spell-check job. |
| .github/workflows/cd.yml | Enables CD on PRs and comments out large parts of the release/build matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
agarny
force-pushed
the
cleaning-up
branch
2 times, most recently
from
39d929d to
8fa8e22
Compare
agarny
force-pushed
the
cleaning-up
branch
4 times, most recently
from
7fa2ef0 to
315a941
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.