chore: remove Blacksmith workflow#257
Merged
Merged
Conversation
Cache corruption issue resolved with Vercel-native builds. Build time: ~42s locally, expected ~2-3min on Vercel. Removing Blacksmith CI/CD workflow files added in PR #255. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Greptile Overview
Greptile Summary
Removes the Blacksmith CI/CD workflow that was added just hours earlier, reverting to direct Vercel deployment after resolving the cache issue that prompted its creation.
Key changes:
- Deleted
.github/workflows/ci-cd.yml(141 lines) - Blacksmith-powered workflow with tests, builds, and Vercel deploys - Deleted
.github/workflows/README.md(153 lines) - Setup documentation for Blacksmith integration .github/workflows/prod-canary.ymlremains active for production health checks
Timeline context:
- Commit
cf20778added Blacksmith workflow to work around Vercel's cache/upload limits - Commit
a2c0bdbfixed the root cache issue - This PR removes Blacksmith since the original problem is resolved
Minor issue found:
apps/web/next.config.mjs:229contains an outdated comment referencing "Re-enable only on faster CI (Blacksmith)" that should be updated
Confidence Score: 4/5
- Safe to merge with one minor cleanup needed
- The workflow removal is clean and justified since the cache issue is resolved. Score is 4/5 (not 5) due to the outdated Blacksmith reference in
next.config.mjs:229that should be updated to prevent confusion - Check
apps/web/next.config.mjs:229for the outdated comment reference to Blacksmith
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| .github/workflows/README.md | 5/5 | Removed Blacksmith workflow documentation - clean deletion |
| .github/workflows/ci-cd.yml | 5/5 | Removed Blacksmith CI/CD workflow - clean deletion, existing prod-canary.yml still active |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant GH as GitHub
participant BC as Blacksmith CI (removed)
participant PC as prod-canary.yml
participant V as Vercel
Note over Dev,V: BEFORE (with Blacksmith workflow)
Dev->>GH: Push to main / Open PR
GH->>BC: Trigger ci-cd.yml
BC->>BC: Lint, Type Check, Tests
BC->>BC: Build Next.js app
BC->>V: Deploy to Vercel
BC->>GH: Comment preview URL (PRs)
GH->>PC: Trigger prod-canary.yml
PC->>PC: Run canary tests
Note over Dev,V: AFTER (Blacksmith removed)
Dev->>GH: Push to main / Open PR
GH->>V: Direct Vercel integration
V->>V: Build and deploy
GH->>PC: Trigger prod-canary.yml
PC->>PC: Run canary tests
Additional Comments (1)
-
apps/web/next.config.mjs, line 229 (link)style: Outdated comment references Blacksmith CI which was just removed
2 files reviewed, 1 comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing Blacksmith CI/CD workflow - not needed since cache issue is resolved.