chore: improve code quality with proper error handling and types - #491
Merged
Conversation
- Add console.warn to empty catch blocks in model.ts and app-sidebar.tsx - Replace any[] with ChatFileAttachment type in pending-message.ts - Replace any[] with ChatFileAttachment type in use-persistent-chat.ts - Add OpenRouterModel interface for API response typing in model.ts - Use proper Convex Id<"chats"> type in app-sidebar.tsx - Remove unsafe 'as unknown as' type casts
Contributor
🚀 Preview Deployment Ready
Convex Preview Backend
🤖 Deployed automatically by GitHub Actions |
Member
Author
|
@greptileai review |
The Railway build was failing because @server/convex/_generated/* imports couldn't resolve - the Convex generated files don't exist during web-only builds. Fix by running 'convex codegen' in the server directory first to generate the required type files before building the web app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
any[]types with proper type definitionsChanges
Error Handling
model.ts: Addconsole.warnto localStorage error catches (was silently swallowing errors)app-sidebar.tsx: Addconsole.warnto localStorage error catchesType Safety
pending-message.ts: Replaceany[]withChatFileAttachmentinterfaceuse-persistent-chat.ts: Replaceany[]withChatFileAttachmentinterfacemodel.ts: AddOpenRouterModelinterface for API response typing, removeanyfrom transformModelapp-sidebar.tsx: Use proper ConvexId<"chats">type, remove unsafeas unknown as ChatItem[]castsTesting