fix(web): add cache-busting for favicon and icons - #498
Merged
Conversation
Browsers aggressively cache favicons, often ignoring hard refreshes. Added ?v=2 query parameter to favicon, apple-touch-icon, og:image, twitter:image, and manifest.json icon sources to force cache invalidation after the osschat rebrand.
|
🚅 Deployed to the openchat-pr-498 environment in OpenChat
|
Contributor
🚀 Preview Deployment Ready
Convex Preview Backend
🤖 Deployed automatically by GitHub Actions |
Member
Author
|
@greptileai please review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?v=2query parameter to favicon.ico and apple-touch-icon.png linksProblem
After the osschat rebrand (commit c974aaa), the new favicon wasn't showing in production even after hard refresh. Browsers aggressively cache favicons and often ignore standard cache invalidation.
Solution
Add query parameter version strings (
?v=2) to all icon/image URLs. This forces browsers to treat them as new resources, bypassing cached versions.Files Changed
apps/web/src/routes/__root.tsx- favicon, apple-touch-icon, og:image, twitter:imageapps/web/public/manifest.json- PWA icon sourcesTesting