Skip to content

Add fallback for missing startup time - #3790

Merged
cpetersen5 merged 1 commit into
developfrom
cdp/sign-image-start-time-fix
May 18, 2026
Merged

Add fallback for missing startup time#3790
cpetersen5 merged 1 commit into
developfrom
cdp/sign-image-start-time-fix

Conversation

@cpetersen5

Copy link
Copy Markdown
Contributor

Description

Fix for:

Error: signing ghcr.io/opencost/opencost@sha256:5f37f689557dbb6737a9182b70625bba55bbba843a2caaba5a79746945a56cc6: unmarshal Provenance predicate: parsing time "" as "2006-01-02T15:04:05Z07:00": cannot parse "" as "2006"
error during command execution: signing ghcr.io/opencost/opencost@sha256:5f37f689557dbb6737a9182b70625bba55bbba843a2caaba5a79746945a56cc6: unmarshal Provenance predicate: parsing time "" as "2006-01-02T15:04:05Z07:00": cannot parse "" as "2006"
Error: Process completed with exit code 1.

Related Issues

N/A

User Impact

N/A

Testing

@cpetersen5
cpetersen5 marked this pull request as ready for review May 18, 2026 21:32
Copilot AI review requested due to automatic review settings May 18, 2026 21:32
@cpetersen5
cpetersen5 requested review from ameijer and mbolt35 May 18, 2026 21:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a fallback timestamp in the reusable image-signing GitHub Action so provenance generation does not fail when the supplied workflow start time is empty.

Changes:

  • Documents fallback behavior for the run-started-at input.
  • Captures a UTC RFC3339-style timestamp at action start.
  • Uses the fallback timestamp when STARTED_ON is empty before generating the SLSA predicate.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud

Copy link
Copy Markdown

@mbolt35 mbolt35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@cpetersen5
cpetersen5 added this pull request to the merge queue May 18, 2026
Merged via the queue into develop with commit 50b2dc5 May 18, 2026
21 of 27 checks passed
@cpetersen5
cpetersen5 deleted the cdp/sign-image-start-time-fix branch May 18, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants