fix: wiping metrics on metric-api failures#3846
Merged
Merged
Conversation
ThibaudDauce
commented
Jun 25, 2026
ThibaudDauce
commented
Contributor
- fix Manque de certains indicateurs sur la page dashboard du site datagouv/data.gouv.fr#2044
maudetes
approved these changes
Jun 25, 2026
Comment on lines
+105
to
+106
| visits = get_metrics_for_model("site", None, ["visit_dataset"]) | ||
| if visits is not None: |
Contributor
There was a problem hiding this comment.
Could we use a walrus operator?
Suggested change
| visits = get_metrics_for_model("site", None, ["visit_dataset"]) | |
| if visits is not None: | |
| if visits := get_metrics_for_model("site", None, ["visit_dataset"]): |
Contributor
Author
There was a problem hiding this comment.
It'll match an empty array in the response, not sure it's what we want since we explicitly return None to say "keep the old value", other falsy value may not have the same meaning (even if it's not possible right now)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.