Skip to content

fix(test): replace testify with gomega in controller suite (#143) - #164

Open
MrBeldum wants to merge 1 commit into
opendefensecloud:mainfrom
MrBeldum:fix/swap-testify-gomega-143
Open

fix(test): replace testify with gomega in controller suite (#143)#164
MrBeldum wants to merge 1 commit into
opendefensecloud:mainfrom
MrBeldum:fix/swap-testify-gomega-143

Conversation

@MrBeldum

@MrBeldum MrBeldum commented Sep 4, 2026

Copy link
Copy Markdown

Summary

Replaces the only direct testify/require call in internal/controller/suite_test.go with a gomega NewWithT(t) assertion and drops github.com/stretchr/testify from go.mod.

Fixes #143

Test plan

  • go test ./internal/controller/ -c compiles
  • go.mod / go.sum no longer list testify

Remove the sole direct testify usage so testify can leave go.mod.
Matches the gomega-based assertion suggested in opendefensecloud#143.

Fixes opendefensecloud#143
@MrBeldum
MrBeldum requested a review from a team September 4, 2026 17:22
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 2a80bfb1-571d-45b9-be32-955ff6b288d5


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@BergCyrill

BergCyrill commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for picking this up @MrBeldum.
There is a blocker for now: This repository requires signed commits on main. We haven't written it down anywhere (but it should be visible in the PR) - that's on us and it will go into a contributing guideline shortly. We will also move to an assigned-issue-contribution approach then.
For now please amend your commit with a valid signing key.

I am also not sure whether the bump of k8s from 0.36 to 0.37 was intentional here - summary & commit message does not reflect that. Please explain to me why you did this in the same PR.

If signing isn't something you are currently able to setup that is no problem at all - just close the PR and the issue can be assigned to someone else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Swap testify for gomega standalone assertion

2 participants