fix(test): replace testify with gomega in controller suite (#143) - #164
fix(test): replace testify with gomega in controller suite (#143)#164MrBeldum wants to merge 1 commit into
Conversation
Remove the sole direct testify usage so testify can leave go.mod. Matches the gomega-based assertion suggested in opendefensecloud#143. Fixes opendefensecloud#143
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for picking this up @MrBeldum. I am also not sure whether the bump of k8s from 0.36 to 0.37 was intentional here - summary & commit message does not reflect that. Please explain to me why you did this in the same PR. If signing isn't something you are currently able to setup that is no problem at all - just close the PR and the issue can be assigned to someone else. |
Summary
Replaces the only direct
testify/requirecall ininternal/controller/suite_test.gowith a gomegaNewWithT(t)assertion and dropsgithub.com/stretchr/testifyfromgo.mod.Fixes #143
Test plan
go test ./internal/controller/ -ccompilesgo.mod/go.sumno longer list testify