Merged
Conversation
… implement caching Add ProjectExistance methods
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
hrcornejo
requested changes
Feb 25, 2026
| } | ||
| return exists; | ||
| } catch (KubernetesClientException e) { | ||
| log.debug("Secret '{}' does not exist in namespace '{}'", secretName, namespace); |
Collaborator
There was a problem hiding this comment.
Better add also exception info to avoid lost it.
Collaborator
Author
There was a problem hiding this comment.
Improved, following the same approach in other methods, depending of the kind error raised by the client framework.
…istence checks and add detailed error logging; add launch and settings configuration files for debugging
📊 Static Analysis Summary🔍 Code Quality Checks
📦 Download detailed reports from the workflow artifacts. |
hrcornejo
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to external service integrations, focusing on improved caching, migration to the Fabric8 OpenShift client, and dependency updates. The most important changes include adding caching to both Jira and OpenShift clients, replacing the OpenShift HTTP client with Fabric8, updating dependencies (notably Spring Boot and Java versions), and expanding test coverage for Jira service edge cases.
External Service Integration Improvements
external-service-ocpfrom a custom HTTP implementation to the Fabric8 OpenShift client,external-service-jira, with more precise conditions for cache usageNew OpenShift Client Features
projectExists)canGetSecrets).