refactor(html)!: cut translate to its four inputs

[andiwand]

🤖 Generated with Claude Code

PR 4 of the v7 API plan.

html::translate had twenty overloads answering four questions.

The ten cache_path ones

Removed. The header already documented the parameter as ignored, and the
implementation was ten one-line forwards under a comment saying so. Nothing on
the render path writes to disk.

The interesting part is what the callers were doing with it. cli/server.cpp
built a directory per prefix and remove_all'd a cache root on startup;
test/html_test.cpp and the media/image tests each built a path to hand over.
All of it fed a parameter that was discarded — so this PR deletes a fair amount
of create_directories that made directories nobody wrote into.

The six narrowed-handle ones

translate(TextFile), (ImageFile), (ArchiveFile), (DocumentFile),
(PdfFile), (FontFile) are gone from the header. They are not lost work —
translate(DecodedFile) dispatches to every one of them, so they stay exactly
where they were, as file-local helpers behind the dispatcher:

namespace {
HtmlService translate_text_file(const TextFile &, const HtmlConfig &, const Logger &);
HtmlService translate_image_file(const ImageFile &, ...);
...
}  // namespace

Two of them delegate back out to html::translate and now say so with a
qualified name — an anonymous namespace in odr does not see odr::html, which
the previous html::translate(...) definition context did.

What remains

Four, for the four inputs that genuinely differ:

HtmlService translate(const DecodedFile &, const HtmlConfig &, const Logger & = …);
HtmlService translate(const Document &,   const HtmlConfig &, const Logger & = …);
HtmlService translate(const Filesystem &, const HtmlConfig &, const Logger & = …);
HtmlService translate(const Archive &,    const HtmlConfig &, const Logger & = …);

Bindings

The cache argument goes from all of them, so this is breaking for every
consumer:

	before	after
Java	Html.translate(file, cachePath, config)	Html.translate(file, config)
Python	pyodr.html.translate(file, cache_path, config)	pyodr.html.translate(file, config)
Swift	HtmlTranslator.translate(file:cachePath:config:)	HtmlTranslator.translate(file:config:)

wasm already called the cache-free overloads and is unchanged.

Net −344/+162, most of it deletion.

Verified

Full build (library, CLI, JNI + jar, python module, tests) clean. 195
html*/Html*/*Image*/*Media*/*Font*/*Csv*/*Markdown* gtests, 69
python tests, and the JNI junit suite via ctest --test-dir jni all pass.
Apple and its Swift tests are signature edits with no behaviour change.

Migration

Drop the cache path argument. If you built a directory to pass to it, drop the
directory too — nothing was ever written there.

[andiwand]

🤖 Correction to this PR, found by building the whole v7 series together and running the full suite.

translate(TextFile) is back. I claimed all seven narrowed-handle overloads were reachable through translate(DecodedFile). Six were. TextFile is not:

// html.cpp, in the dispatcher, before the text branch
if (file.file_type() == FileType::xml) {
  return internal::html::create_xml_service(...);   // source view, not lines
}

translate(DecodedFile) deliberately renders an xml as its source view and a csv as a table. Narrowing to TextFile by hand was the only way to ask for the numbered line list instead — the dispatcher's own comment says so ("Translating it as a text file by hand still writes the line list"), and XmlHtml.translating_it_as_a_text_file_still_writes_the_line_list asserts it.

So this cuts twenty overloads to five, not four: DecodedFile, TextFile, Document, Filesystem, Archive. The header now says why TextFile is there.

How I missed it: the verification note above says "195 gtests" — that was a filtered run (html*, Html*, *Image*, *Media*, *Font*, *Csv*, *Markdown*) which does not include XmlHtml.*. I did not run the full suite on this branch, and the claim was broader than the check. Now run: 1460 passed, plus 68 python tests and the JNI junit suite.

The other five removals are unaffected — those really do produce byte-identical output through the dispatcher.