fix: resolve all ruff lint errors#153
Open
Emin017 wants to merge 12 commits into
Open
Conversation
…xplicit | None) `get_eda_instance` and the per-step `run_*` functions declared `ecc_module: ECCToolsModule = None` (implicit-Optional) and `get_eda_instance` returned `-> ECCToolsModule` despite returning None on its failure path. These functions already handle None correctly at runtime — each reassigns via `get_eda_instance(...)` and guards with `if ecc_module is not None:` — so only the annotations were wrong. The mistyped signatures forced pyright to flag every None-origin argument down the call chain, including the 4 errors in ecc_dreamplace/runner.py. Fix the root: `get_eda_instance(ecc_module: ECCToolsModule | None = None) -> ECCToolsModule | None`, and the 13 `run_*` `ecc_module` params to `ECCToolsModule | None = None` (matching run_step/run_sta_without_spef which were already correct). Behavior-neutral. ecc_dreamplace/runner.py: 4 → 0 pyright errors; ecc/runner.py: 80 → 44 (cleared 36 pre-existing None-cascade errors, introduced none). Zero new ruff. Full pytest 1036 passed.
UP009 drop obsolete encoding declarations, UP015 redundant open modes, UP045 Optional[X] -> X | None, UP006 typing.Dict/List -> builtins, UP032 .format -> f-string, UP035 remove deprecated typing import in utility/filelist.py. Includes the earlier runner.py autofix batch (I001/F401/F841/UP009/UP032) whose hunks are entangled with UP009. Gate: ruff --select UP = 0; pytest 1036 passed; per-file pyright diagnostic multisets identical before/after (repo-wide pyright counts fluctuate run-to-run, per-file is the trustworthy gate).
Pure line-wrapping, no behavior change: hanging-indent call args, parenthesized boolean chains, implicit-concat f-string splits. Gate: ruff E501 68 -> 0 with all other rule counts byte-identical; pytest 1036 passed; per-file pyright diagnostic multisets identical.
Signed-off-by: Emin <me@emin.chat>
Signed-off-by: Emin <me@emin.chat>
Emin017
force-pushed
the
emin/resolve-ruff-lint
branch
from
July 21, 2026 13:32
317f165 to
e039bfe
Compare
Signed-off-by: Emin <me@emin.chat>
Emin017
marked this pull request as ready for review
July 22, 2026 07:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Scope
Select the areas touched by this PR:
uv.lock, or release artifacts.Validation
List the commands you ran. Mark checks that are not applicable as N/A.
uv run pytest test/uv run ruff check chipcompiler testuv run ruff format --check chipcompiler testecc --help,ecc --version,ecc version --jsonnix run .#cli -- --helpSkipped checks and reason:
Runtime And Packaging Impact
ecc-toolsorecc-dreamplacedependency changedNotes:
Checklist