Skip to content

Conversation

@michaelroytman
Copy link
Contributor

No description provided.

@michaelroytman michaelroytman force-pushed the mroytman/address-tuple-list-issue branch from d2a96f0 to 2881b6b Compare August 27, 2019 14:42
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #23   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         363    363           
  Branches       48     48           
=====================================
  Hits          363    363

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d4b0d...2881b6b. Read the comment docs.

@michaelroytman
Copy link
Contributor Author

For reference, the issue discovered when attempting to upgrade the version of django-user-tasks to 0.1.8 in the bokchoy and a11y test suites. The error was:

14:03:45  ERRORS:
14:03:45  <class 'user_tasks.admin.UserTaskArtifactAdmin'>: (admin.E031) The value of 'ordering' must be a list or tuple.
14:03:45  <class 'user_tasks.admin.UserTaskArtifactAdmin'>: (admin.E031) The value of 'ordering' must be a list or tuple.
14:03:45  <class 'user_tasks.admin.UserTaskStatusAdmin'>: (admin.E031) The value of 'ordering' must be a list or tuple.
14:03:45  <class 'user_tasks.admin.UserTaskStatusAdmin'>: (admin.E031) The value of 'ordering' must be a list or tuple.

Changed
+++++++

* Improve list display for `ModelAdmin`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added in a CHANGELOG entry for the previous release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that!

Copy link

@Andytr1 Andytr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing it!

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. My bad!

@michaelroytman michaelroytman merged commit dfcb68a into master Aug 27, 2019
@michaelroytman michaelroytman deleted the mroytman/address-tuple-list-issue branch August 27, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants