-
Notifications
You must be signed in to change notification settings - Fork 17
feat: add django 5.2 support #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @UsamaSadiq! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
c8b003f to
d168004
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #412 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 433 435 +2
Branches 47 47
=========================================
+ Hits 433 435 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b2f95f7 to
f5e2acc
Compare
f5e2acc to
4b47ff3
Compare
| """ | ||
| Get the default storage backend or for the given import path. | ||
| """ | ||
| return storages["default"] if import_path is None else storages[import_path] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@UsamaSadiq you might need to run this on sandbox before merging in platform.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current implementation might not work in production because there’s no STORAGES dictionary defined in the edx-platform production.py settings file and with default storage it will bring django default settings.
e.g
{'_backends': {'default': {'BACKEND': 'django.core.files.storage.FileSystemStorage'}, 'staticfiles': {'BACKEND': 'django.contrib.staticfiles.storage.StaticFilesStorage'}}, '_storages': {}, 'backends': {'default': {'BACKEND': 'django.core.files.storage.FileSystemStorage'}, 'staticfiles': {'BACKEND': 'django.contrib.staticfiles.storage.StaticFilesStorage'}}}
USER_TASKS_ARTIFACT_STORAGE uses the S3Boto3 storage class, as seen here:
With the current changes, the import path would resolve to cms.djangoapps.contentstore.storage.ImportExportS3Storage.
Attempting to use storages[import_path] will raise an InvalidStorageError because the STORAGES setting does not include this path as a registered alias.
To fix this and ensure it works in production, you should dynamically import the class using:
from django.utils.module_loading import import_string
import_string(import_path)
This approach does not rely on the STORAGES dictionary and is compatible with the current production configuration.
I would suggest you to add some tests in this repo. like Irtaza added in edx-val.
cc @irtazaakram
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going through the suggestion solution and creating a fix PR for this issue
Description
Django 5.2support under theDjango 5.2upgrade effort.3.4.0and updated the CHANGELOG