Skip to content

Conversation

@UsamaSadiq
Copy link
Member

@UsamaSadiq UsamaSadiq commented Apr 4, 2025

Description

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 4, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 4, 2025

Thanks for the pull request, @UsamaSadiq!

This repository is currently maintained by @usamasadiq.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 4, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 7, 2025
@UsamaSadiq UsamaSadiq marked this pull request as ready for review April 11, 2025 13:03
@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b122334) to head (4b47ff3).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #412   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          433       435    +2     
  Branches        47        47           
=========================================
+ Hits           433       435    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@UsamaSadiq UsamaSadiq force-pushed the django52-support branch 7 times, most recently from b2f95f7 to f5e2acc Compare April 11, 2025 15:44
@UsamaSadiq UsamaSadiq merged commit ac17509 into master Apr 11, 2025
13 checks passed
@UsamaSadiq UsamaSadiq deleted the django52-support branch April 11, 2025 15:57
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Apr 11, 2025
"""
Get the default storage backend or for the given import path.
"""
return storages["default"] if import_path is None else storages[import_path]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UsamaSadiq you might need to run this on sandbox before merging in platform.

Copy link
Contributor

@awais786 awais786 May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UsamaSadiq

The current implementation might not work in production because there’s no STORAGES dictionary defined in the edx-platform production.py settings file and with default storage it will bring django default settings.
e.g

{'_backends': {'default': {'BACKEND': 'django.core.files.storage.FileSystemStorage'}, 'staticfiles': {'BACKEND': 'django.contrib.staticfiles.storage.StaticFilesStorage'}}, '_storages': {}, 'backends': {'default': {'BACKEND': 'django.core.files.storage.FileSystemStorage'}, 'staticfiles': {'BACKEND': 'django.contrib.staticfiles.storage.StaticFilesStorage'}}}

USER_TASKS_ARTIFACT_STORAGE uses the S3Boto3 storage class, as seen here:

https://github.com/openedx/edx-platform/blob/489dc774bb8f15881611ba398810fb6055c1b8f4/cms/envs/production.py#L276

With the current changes, the import path would resolve to cms.djangoapps.contentstore.storage.ImportExportS3Storage.

Attempting to use storages[import_path] will raise an InvalidStorageError because the STORAGES setting does not include this path as a registered alias.

To fix this and ensure it works in production, you should dynamically import the class using:

from django.utils.module_loading import import_string
import_string(import_path)

This approach does not rely on the STORAGES dictionary and is compatible with the current production configuration.

I would suggest you to add some tests in this repo. like Irtaza added in edx-val.

cc @irtazaakram

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going through the suggestion solution and creating a fix PR for this issue

@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add Django 5.2 support to django-user-tasks

5 participants