Skip to content

Upgrade to Bootstrap v4.0.0. Bump to 1.0.0.#26

Merged
thallada merged 3 commits intomasterfrom
thallada/upgrade-bootstrap-v4
Apr 4, 2018
Merged

Upgrade to Bootstrap v4.0.0. Bump to 1.0.0.#26
thallada merged 3 commits intomasterfrom
thallada/upgrade-bootstrap-v4

Conversation

@thallada
Copy link
Contributor

See Bootstrap 4 changelog for breaking changes between v4.0.0-beta.2 and v4.0.0: https://github.com/twbs/bootstrap/releases. I made this the 1.0.0 release because of the breaking changes.

@edx/fedx-team

@thallada thallada force-pushed the thallada/upgrade-bootstrap-v4 branch from b3d810e to 0f95f3c Compare April 2, 2018 17:15
@thallada
Copy link
Contributor Author

thallada commented Apr 2, 2018

I verified that the styles still look okay in Paragon with this branch: https://github.com/edx/paragon/tree/thallada/upgrade-bootstrap

Copy link

@efischer19 efischer19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My opinion: 🚢

Copy link
Contributor

@arizzitano arizzitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thallada thallada merged commit fd9d7b0 into master Apr 4, 2018
@thallada thallada deleted the thallada/upgrade-bootstrap-v4 branch April 4, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants