Skip to content

feat: Remove deprecated analytics filters#690

Merged
bcitro merged 7 commits into
openedx:masterfrom
jdhanenkula:djyothi/ENT-11979
Jul 9, 2026
Merged

feat: Remove deprecated analytics filters#690
bcitro merged 7 commits into
openedx:masterfrom
jdhanenkula:djyothi/ENT-11979

Conversation

@jdhanenkula

@jdhanenkula jdhanenkula commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description

This PR removes deprecated learner filters from the Enterprise Data as part of ENT-11979.

Changes

  • Updated admin_analytics/database/tables/fact_engagement_admin_dash.py to remove the deprecated is_engaged and has_passed filters from the leaderboard query filters.
  • Updated the analytics query filter logic to stop accepting these deprecated request parameters.
  • Updated [test_analytics_leaderboard.py](http://test_analytics_leaderboard.py/) and [mock_analytics_data.py](http://mock_analytics_data.py/) to reflect the removal of the deprecated filters.
  • Verified that the leaderboard and analytics endpoints continue to return the expected data without these filters.
  • Version bump to 10.22.9 + CHANGELOG entry.

Jira

ENT-11979

Testing

  • pytest enterprise_data/tests/admin_analytics/test_analytics_leaderboard.py → 6 passed.
  • Lint clean (pylint).
image

@rgopalrao-sonata-png rgopalrao-sonata-png left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write the relevant description and add the test cases

@jdhanenkula jdhanenkula changed the title feat: Leaderboard adjustments feat: Remove deprecated analytics filters Jun 30, 2026

@rgopalrao-sonata-png rgopalrao-sonata-png left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has passed flag is modified, lease check if its required. Add the screenshots of testing

@bcitro bcitro self-assigned this Jul 9, 2026
@bcitro
bcitro requested a review from Copilot July 9, 2026 14:38

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes deprecated learner filtering behavior from the admin analytics leaderboard data path, updating the underlying query filtering, test fixtures, and release metadata to reflect the new (unfiltered) leaderboard semantics.

Changes:

  • Removed the is_engaged equality filter from leaderboard engagement queries in FactEngagementAdminDashTable.
  • Updated leaderboard tests and mock leaderboard fixture data to reflect inclusion of non-engaged/browsing-only learners.
  • Bumped package version to 10.22.9 and added a changelog entry.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
enterprise_data/tests/admin_analytics/test_analytics_leaderboard.py Updates/extends leaderboard tests to validate unfiltered behavior and CSV output.
enterprise_data/tests/admin_analytics/mock_analytics_data.py Adjusts leaderboard mock responses to include browsing-only learning time and updated completion-field naming.
enterprise_data/admin_analytics/database/tables/fact_engagement_admin_dash.py Removes is_engaged from leaderboard query equality filters and updates documentation example.
enterprise_data/init.py Version bump to 10.22.9.
CHANGELOG.rst Adds a 10.22.9 changelog entry for the feature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread enterprise_data/tests/admin_analytics/test_analytics_leaderboard.py
Comment thread enterprise_data/tests/admin_analytics/test_analytics_leaderboard.py Outdated
Comment thread CHANGELOG.rst Outdated
@bcitro

bcitro commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

@jdhanenkula the copilot feedback all looks to be valid, please address that first and then resubmit for review. Thanks!

@bcitro
bcitro merged commit 8f62f99 into openedx:master Jul 9, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants