feat: Remove deprecated analytics filters#690
Merged
Conversation
rgopalrao-sonata-png
suggested changes
Jun 29, 2026
rgopalrao-sonata-png
left a comment
Contributor
There was a problem hiding this comment.
Please write the relevant description and add the test cases
rgopalrao-sonata-png
approved these changes
Jul 3, 2026
There was a problem hiding this comment.
Pull request overview
Removes deprecated learner filtering behavior from the admin analytics leaderboard data path, updating the underlying query filtering, test fixtures, and release metadata to reflect the new (unfiltered) leaderboard semantics.
Changes:
- Removed the
is_engagedequality filter from leaderboard engagement queries inFactEngagementAdminDashTable. - Updated leaderboard tests and mock leaderboard fixture data to reflect inclusion of non-engaged/browsing-only learners.
- Bumped package version to
10.22.9and added a changelog entry.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| enterprise_data/tests/admin_analytics/test_analytics_leaderboard.py | Updates/extends leaderboard tests to validate unfiltered behavior and CSV output. |
| enterprise_data/tests/admin_analytics/mock_analytics_data.py | Adjusts leaderboard mock responses to include browsing-only learning time and updated completion-field naming. |
| enterprise_data/admin_analytics/database/tables/fact_engagement_admin_dash.py | Removes is_engaged from leaderboard query equality filters and updates documentation example. |
| enterprise_data/init.py | Version bump to 10.22.9. |
| CHANGELOG.rst | Adds a 10.22.9 changelog entry for the feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@jdhanenkula the copilot feedback all looks to be valid, please address that first and then resubmit for review. Thanks! |
bcitro
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes deprecated learner filters from the Enterprise Data as part of ENT-11979.
Changes
admin_analytics/database/tables/fact_engagement_admin_dash.pyto remove the deprecatedis_engagedandhas_passedfilters from the leaderboard query filters.[test_analytics_leaderboard.py](http://test_analytics_leaderboard.py/)and[mock_analytics_data.py](http://mock_analytics_data.py/)to reflect the removal of the deprecated filters.Jira
ENT-11979
Testing