Skip to content

Conversation

@taimoor-ahmed-1
Copy link
Contributor

This PR fixes the mysql api for adding a new comment where the thread wasn't getting unread due to last_activity_at not being updated

close #219

@taimoor-ahmed-1 taimoor-ahmed-1 self-assigned this Sep 17, 2025
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 17, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @taimoor-ahmed-1!

This repository is currently maintained by @openedx/wg-maintainers-forums.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Sep 17, 2025
@taimoor-ahmed-1 taimoor-ahmed-1 force-pushed the fix/read_status_not_updating_after_comment branch from d79f6df to 6461081 Compare September 17, 2025 07:57
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Sep 17, 2025
@mphilbrick211 mphilbrick211 requested a review from a team September 17, 2025 13:34
Comment on lines 1506 to 1509
if comment_thread_id:
CommentThread.objects.filter(pk=int(comment_thread_id)).update(
last_activity_at=timezone.now()
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do it like this?? As we already have comment_thread above.

if comment_thread:
    comment_thread.last_activity_at = timezone.now()
    comment_thread.save(update_fields=["last_activity_at"])

This PR fixes the mysql api for adding a new comment where the thread wasn't getting unread due to last_activity_at not being updated
close #219
@taimoor-ahmed-1 taimoor-ahmed-1 force-pushed the fix/read_status_not_updating_after_comment branch from 6461081 to 8bc454c Compare September 22, 2025 11:42
@taimoor-ahmed-1 taimoor-ahmed-1 merged commit e59600a into master Sep 22, 2025
14 checks passed
@taimoor-ahmed-1 taimoor-ahmed-1 deleted the fix/read_status_not_updating_after_comment branch September 22, 2025 11:46
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Read state not updating when the post gets new response/comment

4 participants