feat: added notification UI#340
Merged
Merged
Conversation
sundasnoreen12
changed the title
sundasnoreen12
changed the title
sundasnoreen12
force-pushed
the
sundas/INF-820
branch
3 times, most recently
from
May 22, 2023 09:32
03377ca to
13545da
Compare
sundasnoreen12
force-pushed
the
sundas/INF-820
branch
from
May 22, 2023 10:02
13545da to
5279752
Compare
sundasnoreen12
force-pushed
the
sundas/INF-820
branch
from
May 22, 2023 10:06
5279752 to
e76f5b6
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #340 +/- ##
===========================================
- Coverage 61.87% 43.33% -18.54%
===========================================
Files 15 28 +13
Lines 299 570 +271
Branches 70 108 +38
===========================================
+ Hits 185 247 +62
- Misses 112 310 +198
- Partials 2 13 +11
☔ View full report in Codecov by Sentry. |
sundasnoreen12
force-pushed
the
sundas/INF-820
branch
from
May 23, 2023 05:40
3ef1a0c to
7034d10
Compare
sundasnoreen12
force-pushed
the
sundas/INF-820
branch
from
May 25, 2023 07:03
c606df7 to
5f4fb32
Compare
sundasnoreen12
force-pushed
the
sundas/INF-820
branch
from
May 25, 2023 17:41
5f4fb32 to
8ed18f3
Compare
sundasnoreen12
force-pushed
the
sundas/INF-820
branch
from
May 26, 2023 12:07
189aa33 to
86939a2
Compare
sundasnoreen12
force-pushed
the
sundas/INF-820
branch
2 times, most recently
from
May 30, 2023 06:35
9d1e07c to
a1d19b1
Compare
sundasnoreen12
force-pushed
the
sundas/INF-820
branch
from
June 5, 2023 06:47
5e97c87 to
bbc1588
Compare
sundasnoreen12
force-pushed
the
sundas/INF-820
branch
from
June 5, 2023 07:15
bbc1588 to
3276496
Compare
awais-ansari
suggested changes
Jun 5, 2023
ayesha-waris
force-pushed
the
sundas/INF-820
branch
from
June 6, 2023 08:04
d65e6b2 to
6d02e63
Compare
sundasnoreen12
force-pushed
the
sundas/INF-820
branch
from
June 8, 2023 16:09
4a442d9 to
a211547
Compare
awais-ansari
suggested changes
Jun 9, 2023
ayesha-waris
suggested changes
Jun 9, 2023
sundasnoreen12
force-pushed
the
sundas/INF-820
branch
from
June 12, 2023 07:16
a93f5ba to
e881586
Compare
awais-ansari
approved these changes
Jun 12, 2023
sundasnoreen12
force-pushed
the
sundas/INF-820
branch
from
June 12, 2023 07:56
e881586 to
4e718f8
Compare
ayesha-waris
approved these changes
Jun 14, 2023
ayesha-waris
force-pushed
the
sundas/INF-820
branch
from
June 15, 2023 07:39
bc6f299 to
30e6eed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INF-820
Description
Added Notification Button in Header Component.
Mockup for notifications tray and button: Notifications
Mockup for notifications button and variations: Notifications
The notifications tray is not scrollable. Implemented a load more button.
Added redux structure and binded the UI with the redux store
Screenshots
